? NPM Resource Changed ? ? Maintainers Checked Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
15 May 2022

Pull Request for Issue # .

Summary of Changes

The spacing for inline tags made things appear smushed. This fix better delineates between tags

Testing Instructions

install clean install of J4
install sample blog data
go to very bottom of page and check that image matches
run npm ci to rebuild template.css and check that image matches.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 15 May 2022
avatar N6REJ N6REJ - change - 15 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2022
Category Repository NPM Change
avatar N6REJ
N6REJ - comment - 15 May 2022
avatar N6REJ N6REJ - change - 15 May 2022
Labels Added: NPM Resource Changed ?
avatar N6REJ N6REJ - change - 15 May 2022
Title
fixes spacing for inline tags.
[4.1] Fixes spacing for inline tags.
avatar N6REJ N6REJ - edited - 15 May 2022
avatar chmst
chmst - comment - 16 May 2022

Nice!

avatar Kostelano
Kostelano - comment - 16 May 2022

padding: .5rem .25rem .5rem 0 is better so that the line of text does not move from the left side.

avatar N6REJ
N6REJ - comment - 16 May 2022

padding: .5rem .25rem .5rem 0 is better so that the line of text does not move from the left side.

I was thinking about that.

avatar N6REJ N6REJ - change - 16 May 2022
Labels Added: ? Maintainers Checked
avatar Quy
Quy - comment - 16 May 2022

I have tested this item successfully on 5214587


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37805.

avatar Quy Quy - test_item - 16 May 2022 - Tested successfully
avatar viocassel
viocassel - comment - 16 May 2022

I have tested this item successfully on 5214587


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37805.

avatar viocassel viocassel - test_item - 16 May 2022 - Tested successfully
avatar alikon alikon - change - 17 May 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37805.

avatar bembelimen bembelimen - close - 17 May 2022
avatar bembelimen bembelimen - merge - 17 May 2022
avatar bembelimen bembelimen - change - 17 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-17 18:48:21
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 17 May 2022

Thx

Add a Comment

Login with GitHub to post a comment