? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
15 May 2022

Summary of Changes

Converts the basic API auth plugin to services.

Testing Instructions

  • Enable the basic API auth plugin
  • Make an API request with basic authentication, for example you can use curl or postman

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

avatar laoneo laoneo - open - 15 May 2022
avatar laoneo laoneo - change - 15 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2022
Category Front End Plugins
avatar laoneo laoneo - change - 15 May 2022
Labels Added: ?
avatar laoneo laoneo - change - 15 May 2022
Title
[4.2] Convert basic api auth plugin to services
[4.2] Convert basic API auth plugin to services
avatar laoneo laoneo - edited - 15 May 2022
avatar laoneo laoneo - change - 15 May 2022
The description was changed
avatar laoneo laoneo - edited - 15 May 2022
avatar heelc29
heelc29 - comment - 17 May 2022

Can you please also correct the filenames of the language files in the manifest to: plg_api-authentication_basic(.sys).ini (wrong added in #23424 ?)

<language tag="en-GB">language/en-GB/plg_authentication_api_basic.ini</language>
<language tag="en-GB">language/en-GB/plg_authentication_api_basic.sys.ini</language>

avatar laoneo
laoneo - comment - 17 May 2022

Done

85ec3fb 17 May 2022 avatar laoneo doc
avatar heelc29
heelc29 - comment - 17 May 2022

In other extensions the file in the src folder is in a subfolder Extension. Should it also?

avatar heelc29
heelc29 - comment - 17 May 2022

I have tested this item successfully on 94bbd50

Thanks @laoneo


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803.

avatar heelc29 heelc29 - test_item - 17 May 2022 - Tested successfully
avatar toivo
toivo - comment - 21 May 2022

I have tested this item successfully on 94bbd50

Tested successfully in Joomla 4.2.0-alpha3-dev of 21 May in Wampserver 3.2.8 using PHP 8.0.15.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803.

avatar toivo toivo - test_item - 21 May 2022 - Tested successfully
avatar alikon alikon - change - 21 May 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37803.

avatar roland-d roland-d - change - 21 May 2022
Labels Added: ?
avatar roland-d roland-d - change - 21 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-21 18:18:59
Closed_By roland-d
avatar roland-d roland-d - close - 21 May 2022
avatar roland-d roland-d - merge - 21 May 2022
avatar roland-d
roland-d - comment - 21 May 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment