Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37797] - Fix DebugBar session issue, add DebugBar\JoomlaHttpDriver

? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
15 May 2022

Pull Request for Issue #37784 .

Summary of Changes

DebugBar require $_SESSION to work. And because API Application uses "Runtime session" it crashes.
The solution is to use the same Session interface that Joomla Application. For this I have added JoomlaHttpDriver for DebugBar.

Bonus: Now debug plugin also collect information for API requests under cache/plg_system_debug_api.
However currently in not possible to view in DebugBar, but that for another PR.

Testing Instructions

Please follow #37784

Actual result BEFORE applying this Pull Request

An error

Expected result AFTER applying this Pull Request

No error

Documentation Changes Required

none

avatar Fedik Fedik - open - 15 May 2022
avatar Fedik Fedik - change - 15 May 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2022
Category ⇒ Front End Plugins
81914bc 15 May 2022 avatar Fedik phpcs
avatar Fedik Fedik - change - 15 May 2022
Labels Added: ?
avatar alikon
alikon - comment - 16 May 2022

I have tested this item ✅ successfully on 81914bc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37797.

avatar alikon alikon - test_item - 16 May 2022 - Tested successfully
avatar Fedik
Fedik - comment - 16 May 2022

I have corected AppInterfaces, please re-test

avatar alikon
alikon - comment - 16 May 2022

ok retested

avatar alikon
alikon - comment - 16 May 2022

I have tested this item ✅ successfully on 2b77344

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37797.

avatar alikon alikon - test_item - 16 May 2022 - Tested successfully
avatar toivo toivo - test_item - 22 May 2022 - Tested successfully
avatar toivo
toivo - comment - 22 May 2022

I have tested this item ✅ successfully on 2b77344

Tested successfully in Joomla 4.1.4-rc2-dev of 22 May in Wampserver 3.2.8 using PHP 8.0.15 and Postman.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37797.

avatar alikon alikon - change - 22 May 2022
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 22 May 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37797.

avatar Fedik Fedik - change - 25 May 2022
Labels Added: ?
avatar Fedik
Fedik - comment - 25 May 2022

I have updated the code, to check app session

avatar richard67
richard67 - comment - 25 May 2022

@alikon @toivo Could you test again? Thanks in advance.

avatar toivo toivo - test_item - 25 May 2022 - Tested successfully
avatar toivo
toivo - comment - 25 May 2022

I have tested this item ✅ successfully on 21cfb5a

Tested successfully in Joomla 4.1.4 in Wampserver 3.2.8 using PHP 8.0.15.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37797.

avatar alikon alikon - test_item - 27 May 2022 - Tested successfully
avatar alikon
alikon - comment - 27 May 2022

I have tested this item ✅ successfully on 21cfb5a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37797.

avatar richard67
richard67 - comment - 27 May 2022

Thanks for testing. RTC still set.

@wilsonge Could you approve the changes so GitHub doesn’t show an unresolved review anymore?

avatar bembelimen bembelimen - change - 11 Jun 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-06-11 13:21:34
Closed_By ⇒ bembelimen
avatar bembelimen bembelimen - close - 11 Jun 2022
avatar bembelimen bembelimen - merge - 11 Jun 2022
avatar bembelimen
bembelimen - comment - 11 Jun 2022

Thx

Add a Comment

Login with GitHub to post a comment