User tests: Successful: Unsuccessful:
Pull Request based on the request by Arie from the dutch community and coordinated for 4.2 with @roland-d
Implements an static 404 URL feature into the core redirect plugin
always the 404 page of the template will be used.
You can configure an static 404 page which does not depend on the template used
The new option needs to be documented on the help screens etc.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Front End Plugins |
I can see the benefits of a static 404 page but it should not rely on the redirect component
Well to me its a good fit as what it does is redirecting when there is a 404 thats what the redirect plugin does already too so this just allows to define a static redirect to be used when nothing else is found.
You are not limited to use this feature but you are free to implement an custom 404 via the template anyway.
But please feel free to discuss that with Roland who asked me to contribute exactly this feature from my advanced redirect plugin to the core for 4.2 :-)
@zero-24 I don’t understand the actual result part in the description. To me it reads the same as the expected result, just with different words, maybe due to a typo.
before you could only do it within the template. Now you can do it without the template. i hope its clearer now?
But please feel free to discuss that with Roland who asked me to contribute exactly this feature from my advanced redirect plugin to the core for 4.2 :-)
I did no such thing, I only told Arie to contact you
Anyway, I do think it fits fine in the redirect component because this is doing the actual redirects when you have it enabled. If you do not use the redirect component, the 404 is handled by your template as it is now.
A global 404 is an option too but that will require templates to adhere to such feature but that is out of scope of this PR I would say.
If you do not use the redirect component, the 404 is handled by your template as it is now.
That's why I dont think its the correct way forward. The 404 should not be dependent on the redirect component
A global 404 is an option too but that will require templates to adhere to such feature but that is out of scope of this PR I would say.
No different to the error.php
That looks like a violation to the http specs and is wrong in my opinion and so should not go into the core. You can create a plugin to do this if you really think you want to break your website.
After discussion in the maintainer channel I'm against adding this to core.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-15 18:42:44 |
Closed_By | ⇒ | roland-d | |
Labels |
Added:
Language Change
Documentation Required
?
|
I have tested this item✅ successfully on c56106a
Tested successfully in Joomla 4.2.0-alpha3-dev of 14 May in Wampserver 3.2.8 using PHP 8.0.15.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37795.