[#37788] - [4.2] Convert joomla action log plugin to services
- Fixed in Code Base
- 30 May 2022
- Medium
- Build: 4.2-dev
- # 37788
- Diff
- Digital-Peak:j4/plugins/actionlog/joomla
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the joomla action log plugin to services.
The action log component changes from #37592 are included here too, otherwise we will have a conflict after merge.
@nikosdion you may want to have a look here too.
Testing Instructions
- Enable the joomla action log plugin
- Save an article
- Go to /administrator/index.php?option=com_actionlogs&view=actionlogs
Actual result BEFORE applying this Pull Request
Action log entry is written for an article create action.
Expected result AFTER applying this Pull Request
Action log entry is written for an article create action.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Front End Plugins Unit Tests |
I have tested this item
Tested successfully in Joomla 4.2.0-alpha3-dev of 13 May.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788.
| Labels |
Added:
?
?
|
||
| Category | Administration Front End Plugins Unit Tests | ⇒ | Front End Plugins |
| Labels |
Removed:
?
|
||
Sorry for the very long delay, I am refactoring Joomla's Two Factor Authentication.
Overall it works fine for me, I juts have one question. Since we are going into the trouble of converting the plugin, shouldn't we also convert it to use SubscriberInterface?
At some point in the future #36578 will be merged in the core. Having the plugin use SubscriberInterface would make quick work of converting it once the concrete events classes are written (phase 2 of the work on that PR). It could even serve as a proof of the concept in the core.
Totally optional, just thinking out loud.
@laoneo You can already use SubscriberInterface
For now I would like to leave it with the current events to not break anything.
I have tested this item
Tested successfully in Joomla 4.2.0-alpha3-dev of 22 May in Wampserver 3.2.8 with PHP 8.0.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788.
Suggestion, lower case: encoding="utf-8"
(I don't know if this is related to this issue ?)
To which issue?
To which issue?
I mean, change here too.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788.
Can you give this plugin also a test?
I'm going to do it, but see my comment what I came across during testing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788.
I have tested this item
Joomla! 4.2.0-alpha3-dev Development
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-30 19:27:27 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
@laoneo It has some CS errors: https://ci.joomla.org/joomla/joomla-cms/54000/1/6