No Code Attached Yet
avatar joomleb
joomleb
11 May 2022

Hi guys,
happening on 4.1.3 and also on J 3.10.9

Language Override > I select the Language (Administrator / Site) > New item or Edit > When I perform a Language String Search ( Value or Constant ):

A - Should the result give me only the results of the selected language ?
So, one result for the same language strings...

B - ...OR, Should the result give me all the language files strings in the folders for the same Constant string language / Value ?
So, more results (all languages) for the same language strings (depending on the installed languages)...

As far as I know, here the Joomla Forum discussion, "A" should be the right, while some 3rd parties extensions (like DPCalendar, Solidres) are running in the "B" mode that complicates a lot the Language String Search for Overrides...
I add an image for you:

DPCalendar-languages-strings

Now, I asked to Allon (DPCalendar team leader) and he gently replied to me:
"...I had a deeper look on the code and it is an issue with the override feature which is not using the current language. This needs a bigger refactoring in the CMS. So I suggest you open an issue on the CMS repo. ...it is not DPCalendar related, but affects every extension..."

avatar joomleb joomleb - open - 11 May 2022
avatar joomleb joomleb - change - 11 May 2022
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 May 2022
avatar joomleb joomleb - change - 11 May 2022
The description was changed
avatar joomleb joomleb - edited - 11 May 2022
avatar infograf768
infograf768 - comment - 13 May 2022

It should be A and I confirm the issue.
Looks like the problem comes from the fact that the code is not optimized to fetch the results from the extension's local language folder when the strings are not in the core language folder.

avatar Bakual
Bakual - comment - 16 May 2022

I think this should work: #37809

avatar richard67
richard67 - comment - 16 May 2022

Will it be fixed in 3.10-dev, too?

avatar richard67
richard67 - comment - 16 May 2022

And why in 4.2-dev and not 4.1-dev? Is it considered a new feature?

avatar richard67
richard67 - comment - 16 May 2022

After having discussed this with other maintainers, I think it is ok to fix this in 4.2.

avatar richard67 richard67 - close - 16 May 2022
avatar richard67
richard67 - comment - 16 May 2022

Closing as having a pull request. Please test #37809 . Thanks in advance.

avatar richard67 richard67 - change - 16 May 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-05-16 18:27:57
Closed_By richard67
avatar joomleb
joomleb - comment - 16 May 2022

Will it be fixed in 3.10-dev, too?

@richard67
Thanks and, Please, What about this question ?

avatar richard67
richard67 - comment - 16 May 2022

It seems the answer is: No.

Add a Comment

Login with GitHub to post a comment