Feeling Lucky
?
[#3777] - [#33865] Use $app->enqueueMessage instead of JError and SOME_ERROR_CODE
- Closed
- 14 Jul 2014
- Medium
- Build: staging
- # 3777
- Diff
- zero-24:patch-9
- Foreign ID 33865
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Tracker
Open Point
Here:
https://github.com/zero-24/joomla-cms/blob/patch-9/libraries/joomla/client/helper.php#L222-229
we use
if (class_exists('JError'))
{
$return = JError::raiseWarning('SOME_ERROR_CODE', JText::_('JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED'));
}
else
{
throw new InvalidArgumentException('Invalid user credentials');
}
can this replaced by
throw new InvalidArgumentException(JText::_('JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED'));
Or should we replace the JERROR Statment with
JFactory::getApplication()->enqueueMessage();
| Title |
|
||||||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-14 12:08:46 |