? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
7 May 2022

Pull Request for Issue # .

Summary of Changes

Use the current Node/Npm


schedule

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Yes, all docs that have hardcoded the min version for Node/NPM need an update

avatar dgrammatiko dgrammatiko - open - 7 May 2022
avatar dgrammatiko dgrammatiko - change - 7 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2022
Category NPM Change
avatar dgrammatiko dgrammatiko - change - 7 May 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 7 May 2022
avatar dgrammatiko dgrammatiko - change - 7 May 2022
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2022
Category NPM Change Unit Tests NPM Change
avatar dgrammatiko dgrammatiko - change - 7 May 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2022
Category NPM Change Unit Tests Unit Tests Repository NPM Change
avatar zero-24
zero-24 - comment - 7 May 2022

FYI i have added a signature which should let drone accept the changes to the drone file ;)

avatar dgrammatiko
dgrammatiko - comment - 7 May 2022

Thanks Tobias ?

avatar bembelimen bembelimen - change - 18 May 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-18 16:48:04
Closed_By bembelimen
avatar bembelimen bembelimen - close - 18 May 2022
avatar bembelimen bembelimen - merge - 18 May 2022
avatar bembelimen
bembelimen - comment - 18 May 2022

Thx

avatar HLeithner
HLeithner - comment - 19 May 2022

Seems some of our ci doesn't work with the new version... for example nightlies and PR packager/download

avatar dgrammatiko
dgrammatiko - comment - 19 May 2022

@HLeithner where is the code for those?

avatar HLeithner
HLeithner - comment - 19 May 2022

Hannes and me fixing it now, its at github.com/joomla-projects/docker-images packager branch

avatar dgrammatiko
dgrammatiko - comment - 19 May 2022

@HLeithner let me know if I can somehow help

avatar HLeithner
HLeithner - comment - 19 May 2022

What's the best way to install/update node on debian?

avatar dgrammatiko
dgrammatiko - comment - 19 May 2022

If you have snap: sudo snap install node --classic --channel=18
if not apt-get update && apt-get install snapd then the above command

avatar HLeithner
HLeithner - comment - 19 May 2022
avatar dgrammatiko
dgrammatiko - comment - 19 May 2022

@HLeithner just make sure you go with 18. The 16 on the main repo is ok as the code is expected to be used from devs so switching directly to 18 (skipping 16 that has a 6 or so more months till EOL) would forced more people to update their node. But internal tooling is ok to use 18 (one less update for October)

avatar HLeithner
HLeithner - comment - 19 May 2022

ok, I also wanted to ask this^^

avatar dgrammatiko
dgrammatiko - comment - 19 May 2022
avatar Hackwar
Hackwar - comment - 22 May 2022

This is still not really the way I like it, but anyway. My big problem right now is, that the node:16-alpine docker image has npm 8.5.5 installed, while our package.json requires npm 8.6.0. That means we get an error at the beginning of each npm build. Is there a reason for using npm 8.6.0 as requirement instead of 8.5.5? I don't care which way we go, but I want that error to be gone...

avatar dgrammatiko
dgrammatiko - comment - 22 May 2022

@Hackwar #37830 sets npm min to 8.5.5

avatar Hackwar
Hackwar - comment - 22 May 2022

thx

Add a Comment

Login with GitHub to post a comment