? No Code Attached Yet
avatar brianteeman
brianteeman
5 May 2022

Steps to reproduce the issue

  • Steps to reproduce the issue
  • Enable workflows in the content options with Basic as the default
  • Edit all the Transitions so they have notifications enabled and set the Usergroups to Publisher
  • Ensure that you have users in that group
  • Create a new article and save & close
  • Edit an article and change the stage

Expected result

Notification email sent
image

Actual result

Message says it has been sent but nothing is received
image

avatar brianteeman brianteeman - open - 5 May 2022
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 May 2022
avatar brianteeman
brianteeman - comment - 5 May 2022

The problem is coming from
if ($receiver->authorise('core.manage', 'com_message'))

This restricts the receivers to those with admin access and com_message access.

That's fine if it is the intended behaviour but the implication of the documentation is that it is not the intended behaviour https://docs.joomla.org/Publishing_Workflow/Scenarios/en#Setting_up_Notifications

It would probably be better to send the mail using getMailer instead of com_messages and thats a very easy change to make

avatar roland-d
roland-d - comment - 5 May 2022

I am working on a PR for exactly that. More details will follow later

avatar brianteeman
brianteeman - comment - 5 May 2022

ok I will undo what I have been working on

avatar brianteeman
brianteeman - comment - 7 May 2022

For reference I was following the pattern used for actionlogs as that would make it indeoendent of com_messages and allow for com_,mail_templates support

avatar roland-d
roland-d - comment - 8 May 2022

@brianteeman I like the idea of integrating it into the mail templates. Just I was wondering if we should keep the com_messages there as well. If we donĀ“t use com_messages, what is the use of com_messages but that may be a complete different discussion ?

avatar brianteeman
brianteeman - comment - 8 May 2022

If you use com_messages for this then you are restricted to users who have admin access.

com_messages is still for used for many things

avatar chmst chmst - change - 17 Feb 2023
Labels Added: ?
avatar chmst chmst - labeled - 17 Feb 2023

Add a Comment

Login with GitHub to post a comment