? ? Maintainers Checked Pending

User tests: Successful: Unsuccessful:

avatar Stevec4
Stevec4
4 May 2022

Pull Request for Issue #37733

Summary of Changes

A legacy template may not include the inheritable attribute in the XML
This PR checks if it "empty"

Testing Instructions

Before applying the patch check that you have the warning when viewing the legacy template in the backend

Actual result BEFORE applying this Pull Request

The following warning is presented
Warning: Undefined property: Joomla\CMS\Object\CMSObject::$inheritable

Expected result AFTER applying this Pull Request

No warning message is displayed,

Documentation Changes Required

avatar Stevec4 Stevec4 - open - 4 May 2022
avatar Stevec4 Stevec4 - change - 4 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2022
Category Administration com_templates
avatar dgrammatiko
dgrammatiko - comment - 4 May 2022

I have tested this item successfully on adaee33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37739.

avatar dgrammatiko dgrammatiko - test_item - 4 May 2022 - Tested successfully
avatar richard67
richard67 - comment - 5 May 2022

@Stevec4 @dgrammatiko Do you have a link to a legacy template which could be used for testing?

avatar Quy
Quy - comment - 5 May 2022

I have tested this item successfully on adaee33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37739.

avatar Quy Quy - test_item - 5 May 2022 - Tested successfully
avatar Quy Quy - change - 5 May 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 5 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37739.

avatar bembelimen bembelimen - change - 5 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-05 21:26:36
Closed_By bembelimen
Labels Added: ? Maintainers Checked
avatar bembelimen bembelimen - close - 5 May 2022
avatar bembelimen bembelimen - merge - 5 May 2022
avatar bembelimen
bembelimen - comment - 5 May 2022

Thx

Add a Comment

Login with GitHub to post a comment