Feeling Lucky
NPM Resource Changed
?
[#37730] - [4.2] Module >> Menu Assignment >> chevrons not working correctly fix
- Closed
- 3 May 2022
- Medium
- Build: 4.2-dev
- # 37730
- Diff
- vorayash:4.2-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #37593
Summary of Changes
- To select chevrons, 'i' was used instead of 'span' because of that it was not selecting anything.
Testing Instructions
Go to Modules >> any module >> Menu Assignment tab >> Only on the pages selected
Click on one or two menus to expand them
The chevrons on the left change from .icon-chevron-right to .icon-chevron-down correctly
Now click on >> Expand the Menu Subtrees >> None
Actual result BEFORE applying this Pull Request
The chevrons do not change so some are incorrect
Expected result AFTER applying this Pull Request
The chevrons change correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
vorayash
- comment
- 3 May 2022
So I am supposed to make pull request on 4.1, right?
brianteeman
- comment
- 3 May 2022
you should be able to just rebase it without creating a new pr.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-03 15:32:53 |
| Closed_By | ⇒ | vorayash | |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | JavaScript Repository NPM Change | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
vorayash
- comment
- 3 May 2022
Closed due to conflicts.
This is a bugfix so andnot a new feature so really should be rebased on 4.1