[#37721] - Make the Tags RouteHelper language aware
- Fixed in Code Base
- 20 Jun 2022
- Medium
- Build: 4.1-dev
- # 37721
- Diff
- roland-d:feature/popular-tags-multi-language
User tests: Successful: Unsuccessful:
Summary of Changes
While building a multi-lingual site with tags we found out that the mod_tags_popular module was not producing SEF URLs due to missing the language string. When the menu items had their language set to All (*) it worked fine but when changing them to English (en-GB) and Dutch (nl-NL) the links are no longer working. After some investigation I found out that the Tags RouteHelper does not take the current language into account. This fix resolves that.
Testing Instructions
- Create a Joomla site with 2 languages (here I assume EN and NL)
- Create some Tags associated with the English language
- Create some Tags associated with the Dutch language
- Create some Articles associated with the English language and select some English Tags
- Create some Articles associated with the Dutch language and select some Dutch Tags
- In the English Home menu create a menu entry of the type
List All Tagsand set the language to English - In the English Home menu create a menu entry of the type
Compact List of Tagged Itemsand set the language to English, select a tag used by the English articles and setContent TypetoArticles - In the Dutch Home menu create a menu entry of the type
List All Tagsand set the language to Dutch - In the Dutch Home menu create a menu entry of the type
Compact List of Tagged Itemsand set the language to Dutch, select a tag used by the Dutch articles and setContent TypetoArticles - Create a front-end module of the type
Tags Popularand set the language to English and assign it to a menu item that is set in step 7 - Create a front-end module of the type
Tags Popularand set the language to Dutch and assign it to a menu item that is set in step 9 - Go the URL that links to the menu item created in step 7
- Click on an article shown there
- You should see the module from step 10 on this page
- Notice that the links in the module are not as expected but they contain
component/tags/tag - Go the URL that links to the menu item created in step 9
- Click on an article shown there
- You should see the module from step 11 on this page
- Notice that the links in the module are not as expected but they contain
component/tags/tag - Apply the patch
- Redo step 12 - 14
- You should see the correct URL in the module
- Redo step 16 - 18
- You should see the correct URL in the module
Actual result BEFORE applying this Pull Request
The URLs in the module do not show the correct SEF URL but instead contain component/tags/tag
Expected result AFTER applying this Pull Request
The URLs in the module do show the correct SEF URL according to their menu item
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End Layout Libraries Modules Plugins |
| Title |
|
||||||
It sounds like it, they should test this
| Labels |
Added:
?
|
||
| Category | com_tags Front End Layout Libraries Modules Plugins | ⇒ | com_tags Front End Layout Modules Plugins |
@roland-d I spent sometime to test this PR today and it works good for me. The only thing left is that in RouteHelper class, we have getTagsRoute() method, I think we should add support for $language parameter, too. Could you please look at it? This method is not used in the core, but I think the code should be consistent. After that, I can mark my test success for the PR. Thanks.
@joomdonation I have added the language as option to the getTagsRoute() as well. I did not look at it before as I am not using it either :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37721.
I had the same issue for a very long time. I would like to thank to all the contributors. I have a question: Would this fix be affecting Joomla 3.10 as well in the upcoming release? Or only the 4.1?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37721.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37721.
| Labels |
Added:
?
|
||
@wilsonge There is no b/c break here because the default value mimics the old behavior. So by not specifying the language the function works like it currently does.
In 8.1 this breaks. No fix for a bugfix release. In my opinion something for 5.0 because of 8.1 (see: https://onlinephp.io/c/e5394), but moving to 4.2 so you can decide.
| Labels |
Added:
?
Removed: ? |
||
I would like to ask one more time, will this fix be applied to 3.10 as well?
If possible, then the deprecated function should call the new function and not have duplicated code.
So the change is now backward-compatible. Do you want to have it in 4.1 @bembelimen ? Or should we re-test it for 4.2?
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as some code got changed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37721.
| Labels |
Removed:
?
|
||
I have tested this item
Works great now, thanks !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37721.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37721.
I have opened this same issue 1,5 years ago. I am still looking forward to a solution for this since then. But I have to use Joomla 3.10 for one more year for some specific reasons. Please create an update for Joomla 3.10 as well since you already know how to modify the code. Thank you for everyone who have contributed for the solution.
Two good tests. Let's get this in. Thankyou!
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-20 20:58:21 |
| Closed_By | ⇒ | wilsonge |
LGTM overall.
In terms of the b/c. what's the change of
*compared to the query not existing before (i.e. if people in the JLayout don't update their template override is there a behaviour change?)