User tests: Successful: Unsuccessful:
com_contact has two types of fields mail and contact. mail are for fields that are added to the contact form. contact is for fields that are displayed with the contact details.
at some point in time a layout override was added for this. Its fubar and not actually needed because the rendering of the different field contexts is already handled in the views (defaulkt_form and default_custom_user_fields)
the main issues caused by these overrides is that the contact fields are not rendered the same as they would have been for an article (dt not dl) and the display of subforms is obviously completely wrong.
Fields are displayed the same across the two components
com_contact has a field layout override that uses a dl etc instead of a ul AND the subform display is fubar
@richard67 I cant remember if i am supposed to add these removed files to script.php or if you deal with it?
@bembelimen @roland-d to me this is a bug fix and should be in 4.1 but I suspect you will say it needs to go in 4.2?
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_contact |
This pull requests has been automatically converted to the PSR-12 coding standard.
Labels |
Added:
?
?
|
Category | Front End com_contact | ⇒ | Unit Tests Administration com_admin |
looks like the psr12 pull requests completely messed up this pr :(
Labels |
Added:
?
|
fixed the issues from the psr12 pr
Category | Unit Tests Administration com_admin | ⇒ | Front End com_contact |
Labels |
Removed:
?
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
@brianteeman Could you solve the conflict? Thanks in advance.
Labels |
Added:
?
|
@brianteeman Could you solve the conflict? Thanks in advance.
done as requested
Labels |
Removed:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-22 21:49:43 |
Closed_By | ⇒ | fancyFranci |
Thank you! :)
@brianteeman I will deal with it.