? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 May 2022

com_contact has two types of fields mail and contact. mail are for fields that are added to the contact form. contact is for fields that are displayed with the contact details.

at some point in time a layout override was added for this. Its fubar and not actually needed because the rendering of the different field contexts is already handled in the views (defaulkt_form and default_custom_user_fields)

the main issues caused by these overrides is that the contact fields are not rendered the same as they would have been for an article (dt not dl) and the display of subforms is obviously completely wrong.

Steps to reproduce the issue

1. Com content

  • Create 3 text fields
  • Create 1 subform field containing the 3 text fields
  • create article and complete the fields

2. com contact - context contact

  • Create 3 text fields
  • Create 1 subform field containing the 3 text fields

3. com contact - context mail

  • Create 3 text fields
  • Create 1 subform field containing the 3 text fields
4. test
  • create contact and complete the fields
  • compare the display of the fields in the front end

Expected result

Fields are displayed the same across the two components

Actual result

com_contact has a field layout override that uses a dl etc instead of a ul AND the subform display is fubar

com_content

image

com_contact

image

image

After PR

image

Additional comments

@richard67 I cant remember if i am supposed to add these removed files to script.php or if you deal with it?

@bembelimen @roland-d to me this is a bug fix and should be in 4.1 but I suspect you will say it needs to go in 4.2?

avatar brianteeman brianteeman - open - 1 May 2022
avatar brianteeman brianteeman - change - 1 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2022
Category Front End com_contact
avatar richard67
richard67 - comment - 1 May 2022

@richard67 I cant remember if i am supposed to add these removed files to script.php or if you deal with it?

@brianteeman I will deal with it.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2022
Category Front End com_contact Unit Tests Administration com_admin
avatar brianteeman
brianteeman - comment - 12 Jul 2022

looks like the psr12 pull requests completely messed up this pr :(

avatar brianteeman brianteeman - change - 15 Jul 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 15 Jul 2022

fixed the issues from the psr12 pr

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jul 2022
Category Unit Tests Administration com_admin Front End com_contact
avatar brianteeman brianteeman - change - 24 Jul 2022
Labels Removed: ?
avatar Quy Quy - test_item - 8 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 8 Feb 2023

I have tested this item successfully on ba7d87f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37716.

avatar viocassel viocassel - test_item - 15 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 15 Feb 2023

I have tested this item successfully on ba7d87f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37716.

avatar richard67 richard67 - change - 15 Feb 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 15 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37716.

avatar richard67
richard67 - comment - 15 Feb 2023

@brianteeman Could you solve the conflict? Thanks in advance.

avatar brianteeman brianteeman - change - 15 Feb 2023
Labels Added: ?
avatar brianteeman
brianteeman - comment - 15 Feb 2023

@brianteeman Could you solve the conflict? Thanks in advance.

done as requested

avatar richard67
richard67 - comment - 15 Feb 2023

RTC is still valid because the commit after the human tests was a clean conflict resolution. The conflict was in file "render.php" and came from PR #39616 , which changed array syntax in that file which is then removed with this PR here.

avatar fancyFranci fancyFranci - change - 22 Feb 2023
Labels Removed: ?
avatar fancyFranci fancyFranci - change - 22 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-22 21:49:43
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 22 Feb 2023
avatar fancyFranci fancyFranci - merge - 22 Feb 2023
avatar fancyFranci
fancyFranci - comment - 22 Feb 2023

Thank you! :)

avatar laoneo
laoneo - comment - 8 May 2023

This pr broke the way custom fields are rendered in mails. Now the contain the HTML code as when they get rendered in a web page. Please test #40557 which restores the old behavior while keeping the new feature from this pr when rendered in a web page.

Add a Comment

Login with GitHub to post a comment