bug PR-4.3-dev ? Pending

User tests: Successful: Unsuccessful:

avatar shazmasiddiqui
shazmasiddiqui
1 May 2022

Pull Request for Issue #37698

Testing Instructions

Enable ReCaptcha and custom fields in registration form and check the position of ReCaptcha. It should be placed at the bottom of the form, right before Register button.

Actual result BEFORE applying this Pull Request

The ReCaptcha is placed before custom fields, in the middle of the form

Expected result AFTER applying this Pull Request

The ReCaptcha should be placed before the Register button

avatar shazmasiddiqui shazmasiddiqui - open - 1 May 2022
avatar shazmasiddiqui shazmasiddiqui - change - 1 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2022
Category Front End com_users
avatar shazmasiddiqui shazmasiddiqui - change - 1 May 2022
Labels Added: ?
avatar richard67
richard67 - comment - 1 May 2022

@shazmasiddiqui Check our coding standards: https://developer.joomla.org/coding-standards/introduction.html . And a useful hint: Adjust your editor in a way so that you can see and distinguish tabs and spaces.

avatar shazmasiddiqui
shazmasiddiqui - comment - 1 May 2022

@richard67 Thankyou for your helpful suggestions. I will keep these suggestions in mind for my next PR's.

avatar richard67
richard67 - comment - 1 May 2022

@shazmasiddiqui You don't always need to update your branch when it is shown as not up to date with the base branch on GitHub. You only need to do that when GitHub shows that there are conflicting files, which was not the case.

avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull requests has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar obuisard
obuisard - comment - 2 Jun 2023

Shazma @shazmasiddiqui, does the PR #38604 fix the issue?

avatar obuisard obuisard - change - 9 Jun 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-06-09 22:14:58
Closed_By obuisard
Labels Added: bug PR-4.3-dev ?
Removed: ?
avatar obuisard
obuisard - comment - 9 Jun 2023

This has been addressed with #38604.
Thank you for your PR!

avatar obuisard obuisard - close - 9 Jun 2023

Add a Comment

Login with GitHub to post a comment