Feeling Lucky
?
?
[#3768] - [#33855] Pagination Unit Tests
- Closed
- 16 Oct 2014
- Medium
- Build: staging
- # 3768
- Diff
- wilsonge:paginationtests
- Foreign ID 33855
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
More Details
Add an optional Application param to the constructor to allow us to unit test things which depend whether we're in the site or the administrator section of the CMS. Added a couple of extra unit tests to demonstrate this improved functionality
Testing
Check pagination continues to work in front and backend. Observe unit tests still pass.
| Title |
|
||||||
| Description | ⇒ | <h2>More Details</h2> <p>Add an optional Application param to the constructor to allow us to unit test things which depend whether we're in the site or the administrator section of the CMS. Added a extra unit test to demonstrate this improved functionality</p> <h2>Testing</h2> <p>Check pagination continues to work in front and backend. Observe unit tests still pass.</p> | |||||
| Labels |
Added:
?
?
|
||||||
brianteeman
- | Status | New | ⇒ | Pending |
| Labels |
Removed:
?
|
||
| Category | ⇒ | Unit Tests |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
wilsonge
- comment
- 16 Oct 2014
merged in staging!
nicksavov
- comment
- 16 Oct 2014
Thanks George!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-16 12:57:27 |
wilsonge
- comment
- 16 Oct 2014
You guys should be fairly easily be able to get 100% test coverage with this I think
mbabker
- comment
- 16 Oct 2014
Quality, not quantity 
Could you update the latest staging?