? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
26 Apr 2022

Pull Request for Issue # .

Summary of Changes

Parks image doesn't display properly due to improper relative path.

Testing Instructions

Install sample testing data.
Click on "parks" on the menu at the top
Notice that the image does not display.
Verify the url for the image is "http://j4.local/index.php/images/sampledata/parks/banner_cradle.jpg" ( your uri will be different of course )
view that the image displays.
verify url for the image is "http://j4.local/images/sampledata/parks/banner_cradle.jpg"

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

avatar N6REJ N6REJ - open - 26 Apr 2022
avatar N6REJ N6REJ - change - 26 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2022
Category Front End Plugins
avatar brianteeman
brianteeman - comment - 27 Apr 2022

see #37663

avatar Quy
Quy - comment - 28 Apr 2022

My local testing is in a subdirectory http://localhost/joomla-cms-4.1-dev/ and not in the root so this PR will not be a correct fix.
Enable Use URL Rewriting and it will not be an issue.

avatar brianteeman
brianteeman - comment - 28 Apr 2022

I have tested this item ? unsuccessfully on cccd072


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37674.

avatar brianteeman brianteeman - test_item - 28 Apr 2022 - Tested unsuccessfully
avatar N6REJ
N6REJ - comment - 30 Apr 2022

My local testing is in a subdirectory http://localhost/joomla-cms-4.1-dev/ and not in the root so this PR will not be a correct fix. Enable Use URL Rewriting and it will not be an issue.

Mine is a sub as well...
www/j4/.....

We had this exact same issue several years ago when the router was changed.

avatar N6REJ
N6REJ - comment - 30 Apr 2022

I have tested this item ? unsuccessfully on cccd072

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37674.

How was it unsuccessful, please show the failure. Just because you don't like the fix doesn't mean it doesn't work.

avatar brianteeman
brianteeman - comment - 30 Apr 2022

Before PR
image

image

After PR
image

image

avatar brianteeman
brianteeman - comment - 5 May 2022

this really should be closed

avatar Quy Quy - change - 5 May 2022
Labels Added: ?
avatar N6REJ
N6REJ - comment - 5 May 2022

No, it shouldn't.
The "default" dataset returns
image
which is incorrect.
"http://j4.local/index.php/images/sampledata/parks/banner_cradle.jpg"
image
is off yet is clearly being left on even with .htaccess and url rewriting going on.

IF infact we do remove the testing sample dataset then that is a different issue.

avatar brianteeman
brianteeman - comment - 5 May 2022
  1. Add suffix to URL is nothing to do with this
  2. I already showed that this PR does not work
avatar N6REJ
N6REJ - comment - 10 May 2022

your test doesn't even make sense... if the image showed pre-fix why would I change it? and how would adding a "/" change the url so dramatically. I'll retest yet again with a clean ( again ) install.

avatar N6REJ
N6REJ - comment - 15 May 2022

sample "test" data option has been removed from 4.1-x So I'm closing this

avatar N6REJ N6REJ - close - 15 May 2022
avatar N6REJ N6REJ - change - 15 May 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-05-15 10:48:34
Closed_By N6REJ
avatar brianteeman
brianteeman - comment - 15 May 2022

sample "test" data has NEVER EVER been part of any joomla release

Add a Comment

Login with GitHub to post a comment