[#37652] - [4.1] Fire change events consistently on the media Field
- Closed
- 30 Apr 2022
- Medium
- Build: 4.1-dev
- # 37652
- Diff
- dgrammatiko:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #37640 .
Summary of Changes
- Call the Custom Element function setValue instead of manually updating the value
Testing Instructions
- Edit an article and go to the images tab
- Open the inspector and inspect the intro image input (the one left to the select button bellow the image)
- type in the browser's console
$0.addEventListener('change', (e) => console.log(e)) - Select an image, check that a change event was recorded in the console
- Clear the field, check the recorded event
- Select another image and check that the event was recorded again
Actual result BEFORE applying this Pull Request
No event on image selection
Expected result AFTER applying this Pull Request
Documentation Changes Required
No this is a bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | JavaScript Repository NPM Change | ⇒ | Unit Tests Administration com_cache com_config com_contact com_content com_finder com_languages com_media com_menus com_redirect com_templates com_users Language & Strings Modules |
@dgrammatiko I think the problem with the branch sync will be solved after the next upmerge from 4.1-dev to 4.2-dev and then update of the branch of this PR to 4.2-dev. As there is an alpha-2 release scheduled for tomorrow, I assume the upmerge will happen just after that.
@richard67 sure but I have no clue why this small bug fix needs to wait few months in order to be (potentially) merged. It's not very helpful for those devs that have a problem with the field right now. Anyways, not my call, just seems not very dev friendly approach
@richard67 sure but I have no clue why this small bug fix needs to wait few months in order to be (potentially) merged.
@dgrammatiko Maybe you misunderstood or I explained wrong. Tomorrow is 4.2 alpha-2 and after that the upmerge, so your PR can be tested and RTC'ed on the day after tomorrow, I would think.
@dgrammatiko P.S. Ah .. you mean the rebase decision? Well I don't know why that was made. @laoneo ?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-30 11:28:10 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
?
Language Change
?
Removed: NPM Resource Changed ? |
||
@richard67 this should be already fixed for 4.2 with #37654, so this isn’t needed anymore
@dgrammatiko Thanks.
Unless the fix is ok for 4.1, then I can redo this PR (2 lines or whatever)
Unless the fix is ok for 4.1, then I can redo this PR (2 lines or whatever)
@bembelimen I think that's on you to decide.
Can you rebase this to 4.2?