@brianteeman The system tests are failing for this PR, and I think it could be related to your changes so the tests might need some changes, too. See the log here https://ci.joomla.org/joomla/joomla-cms/53603/1/30 :

 I delete field "Field title","Field deleted"
   I am on page "/administrator/index.php?option=com_fie..."
  [GET] http://localhost/mysql/administrator/index.php?option=com_fields&view=fields&context=com_content.article
   I get config "timeout"
   I wait for element {"id":"filter_search"},90
   I execute js "[].forEach.call(document.querySelectorA..."
   I select option "//*[@id="filter_state"]","-2"
   I wait 2
   I fill field {"id":"filter_search"},"Field title"
   I click {"id":"filter_search"}
   I check all results 
  Selecting Checkall button
   I wait 2
   I click toolbar button "Empty trash"
   I get config "timeout"
   I wait for text "Field deleted",90,{"id":"system-mess...}
  Screenshot and page source were saved into '/********/src/tests/Codeception/_output/' dir
 ERROR 

The screenshot then looks like this: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.1-dev/37650/system-tests/53603/ContentFieldListCest.Field.mysql.fail.png

Will try to get someone to advise with the system tests.

The system test needs to be adapted of fields. Something like here shuould probably work https://github.com/joomla/joomla-cms/blob/4.1-dev/tests/Codeception/_support/Step/Acceptance/Administrator/Content.php#L229.

will take a look this afternoon

@brianteeman I think it needs to replace this line here

https://github.com/joomla/joomla-cms/blob/4.1-dev/tests/Codeception/_support/Step/Acceptance/Administrator/Field.php#L121

by these 2 lines:

$I->wait(2);
$I->acceptPopup();

It seems to work.

This PR brings the behaviour of Empty Trash in Fields to be consistent with all other uses. The test has also been updated to be consistent with all the other tests for Empty Trash.

If the test is incomplete then it is incomplete eveyrwhere and should be updated in its own pull request.

This PR brings the behaviour of Empty Trash in Fields to be consistent with all other uses. The test has also been updated to be consistent with all the other tests for Empty Trash.

If the test is incomplete then it is incomplete eveyrwhere and should be updated in its own pull request.

I would be ok with that.

I have tested this item ✅ successfully on 36524df

Tested successfully in Joomla 4.1.3-dev of 25 April.

I have tested this item ✅ successfully on 36524df

RTC

@laoneo Now as your suggested change has been implemented, please approve the changes on GitHub so the it does not show any requested changes anymore. Thanks in advance.

Previous human test results and RTC status are still valid since the commit after that only changed the system tests, which are still passing.

Thx

thanks