Feature PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Apr 2022

Summary of Changes

  1. Adds an indicator if the category is unpublished or trashed.
  2. Changes the published icon to a disabled icon and adds a tooltip to the icon
  3. changes to use the publishedbutton and featuredbutton

Testing Instructions

Create a category called test and create 4 featured contacts in that category.
Unpublish or Trash the category

Check the list of contacts

Actual result BEFORE applying this Pull Request

No indication that the contact can not be displayed

Expected result AFTER applying this Pull Request

Text as shown in the image below

image

avatar brianteeman brianteeman - open - 24 Apr 2022
avatar brianteeman brianteeman - change - 24 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2022
Category Administration com_contact
avatar brianteeman brianteeman - change - 26 Apr 2022
Labels Added: ?
avatar brianteeman brianteeman - change - 26 Apr 2022
The description was changed
avatar brianteeman brianteeman - edited - 26 Apr 2022
avatar brianteeman brianteeman - change - 26 Apr 2022
The description was changed
avatar brianteeman brianteeman - edited - 26 Apr 2022
avatar toivo
toivo - comment - 30 Apr 2022

I have tested this item ? unsuccessfully on a959bef

Tested in Joomla 4.2.0-alpha3-dev of 30 April.

Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed). When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37631.

avatar toivo toivo - test_item - 30 Apr 2022 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 30 Apr 2022

Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed).

So that is the correct and expected behaviour of this pr

When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised.

That is beyond the scope of this PR. This PR is only for the list view

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar brianteeman brianteeman - change - 12 Jul 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar brianteeman brianteeman - close - 8 Sep 2023
avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-08 12:05:25
Closed_By brianteeman
Labels Added: Feature PR-5.0-dev
Removed: ? ?

Add a Comment

Login with GitHub to post a comment