[#3763] - Fix of Parse error: syntax error - Error introduced in 2.5.21
- Closed
- 12 Jun 2014
- Medium
- Build: 2.5.x
- # 3763
- Diff
- Kubik-Rubik:2.5.x-Fix-Parse-Error-com_contact
User tests: Successful: Unsuccessful:
Fix of Parse error: syntax error, unexpected T_RETURN, expecting T_FUNCTION which was introduced in version 2.5.21
Missing bracket after the if statement
if ($copy_email_activated == true && !empty($data['contact_email_copy']))
- code style optimizations
Reported by user y021ahe in the forum: http://forum.joomla.org/viewtopic.php?f=622&t=848531
The diff for this PR looks strange. Can you do it so it only changes the actual error?
Looks a bit like you worked from staging instead from the 2.5 branch.
@Bakual Thank you for your time to look into it. This PR is correct and I also used the 2.5.x branch to add it. Please check the raw output and you will see that everything is correct:
https://github.com/Kubik-Rubik/joomla-cms/blob/2.5.x-Fix-Parse-Error-com_contact/components/com_contact/controllers/contact.php
For me this error is very critical because the contact form produces the parse error in all Joomla! installations with the version 2.5.21. We should release the version 2.5.22 with this fix as soon as possible.
It's indeed codestyle changes (line indentions) which cause the diff to look strange. When checking with SmartGit it's obvious
Merged, thanks!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-12 08:07:42 |
JoomlaCode entry: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33848