PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
23 Apr 2022

Summary of Changes

Ongoing effort to inject the database into components and get rid of the deprecated Factory::getDbo(); calls. As workflow offers already the possibility to inject the database, this pr changes the usages where a workflow is instantiated to inject the dependencies. Additionally it deprecates the usage of null dependencies and removes some dead code.

Testing Instructions

  • Enable workflow in the articles manager
  • Open the article form

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

avatar laoneo laoneo - open - 23 Apr 2022
avatar laoneo laoneo - change - 23 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2022
Category Administration com_workflow Libraries Front End Plugins
avatar roland-d roland-d - change - 20 Jun 2022
Labels Added: ?
avatar laoneo laoneo - change - 24 Jun 2022
Title
[4.2] Inject the database into workflow
[4.3] Inject the database into workflow
avatar laoneo laoneo - edited - 24 Jun 2022
avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#26

avatar laoneo laoneo - change - 28 Jun 2022
Labels Added: PR-4.3-dev ?
Removed: ?
avatar laoneo laoneo - change - 28 Jun 2022
Labels Added: ?
avatar laoneo laoneo - change - 15 Aug 2022
Labels Removed: ?
avatar laoneo laoneo - change - 15 Dec 2022
Labels Removed: ?
avatar laoneo
laoneo - comment - 19 Jan 2023

Doc article is here joomla/Manual#79

avatar obuisard obuisard - change - 19 Jan 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-19 20:29:44
Closed_By obuisard
avatar obuisard obuisard - close - 19 Jan 2023
avatar obuisard obuisard - merge - 19 Jan 2023
avatar obuisard
obuisard - comment - 19 Jan 2023

Thank you Allon @laoneo !

Add a Comment

Login with GitHub to post a comment