Feeling Lucky
?
PBF
?
[#37604] - [4.2] Inject the database into the banner HTML service
- Fixed in Code Base
- 23 Apr 2022
- Medium
- Build: 4.2-dev
- # 37604
- Diff
- Digital-Peak:j4/banner/inject-db
User tests: Successful: Unsuccessful:
Summary of Changes
Ongoing effort to inject the database into components and get rid of the deprecated Factory::getDbo(); calls.
Testing Instructions
- Create a banners client
- Create a banner
- In the banners list, select a banner and then click on the batch action
Actual result BEFORE applying this Pull Request
The client list in the batch modal shows the new client.
Expected result AFTER applying this Pull Request
The client list in the batch modal shows the new client.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Labels |
Added:
?
|
||
kiki-G
- comment
- 22 Apr 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37604.
kiki-G
- comment
- 22 Apr 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37604.
| Status | Pending | ⇒ | Ready to Commit |
RickR2H
- comment
- 22 Apr 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37604.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-23 19:14:15 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
PBF
|
||
zero-24
- comment
- 23 Apr 2022
Merging thanks
I have tested this item✅ successfully on e2e209f
Patch works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37604.