Feeling Lucky
?
[#37590] - [4.x] Article Manager RTL correction
- Closed
- 21 Apr 2022
- Medium
- Build: 4.1-dev
- # 37590
- Diff
- brianteeman:more_rtl_content
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
User tests: Successful: Unsuccessful:
This PR removes a conditional block from the article manager and the featured article manager that was intended to ensure that the display of the category and nested category was correct when the admin is using an rtl language and the category names may be a mix of LTR and RTL.
Not really sure why but
- this code does not work correctly. the order of the categories is wrong and the « character is wrong
- there is no need for this alternate block of code for RTL
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 21 Apr 2022
Weird - I can't replicate your issue
Quy
- comment
- 21 Apr 2022
Please install Testing Sample Data. Check the 2 articles referenced in the above screenshot. It is fine in Persian before the PR.
brianteeman
- comment
- 21 Apr 2022
Replicated th problem - it is coming from when there are more than 2 categories in the tree and it is truncated. Will look into a fix later tonight
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-21 17:21:50 |
| Closed_By | ⇒ | brianteeman |
Also,
$catSeparatorshould not be in the loop so it is only executed once.