[#3759] - Routing: Introducing unittests for core app router classes
- Closed
- 2 Oct 2014
- Medium
- Build: staging
- # 3759
- Diff
- Hackwar:routing_unittests
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR introduces a large chunk of unittests to document the behavior of the core application routing classes.
This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors
| Labels |
Added:
?
?
|
||
Ok, so, I guess this PR would be ready to test now... 
I guess that means it's time to brave Joomlacode to create a tracker :p
But done a very quick & limited test just now and looks good to me. Will do a more complete test later
Considering that JC has been down quite frequently the last few days, I'd like to ask to not be required to maintain a tracker item on JC...
Any news here?
This PR is still up-to-date
nicksavov
- | Labels |
Removed:
?
|
||
This needs code reviews by maintainers and not tests.
brianteeman
- | Status | New | ⇒ | Pending |
| Category | ⇒ | Unit Tests |
| Category | Unit Tests | ⇒ | SEF Unit Tests |
| Status | Pending | ⇒ | Ready to Commit |
Any news here?
@Bakual @phproberto @mbabker can you guys do the code review?
Love to here the status of this, wil it be in J 3.4 ?
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
jissues-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Don't know how this got RTC, but Imho needs tests as the PR does not only contains unittests but extensive changes in code.
mbabker
- | Milestone |
Added: |
||
phproberto
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-02 02:43:00 |
I'm going to add further commits to this and further test this until we reach 100% code coverage. With the commits above this comment, we got this done for JRouter and JRouterAdministrator.