? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 Apr 2022

The admin component com_media had some hard coded English texts.

Summary of Changes

This PR changes the hard coded English texts to language strings
and adds the translations to administrator/language/en-GB/com_media.ini

avatar pe7er pe7er - open - 20 Apr 2022
avatar pe7er pe7er - change - 20 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2022
Category Administration com_media Language & Strings
avatar brianteeman
brianteeman - comment - 20 Apr 2022

I may be wrong but my undeerstanding was that exception messages were not being translated

avatar pe7er
pe7er - comment - 20 Apr 2022

I found the hard coded text when I was looking for the "Media Provider not found" that a J4 user reported to me when they tried to use Media as Custom Field Type.

If a decision was made to not translate exception messages, then that could explain why these strings weren't translated yet :-)

avatar brianteeman
brianteeman - comment - 20 Apr 2022

It appears to be inconsistent even within the same file and peersonally I don't understand why everything isnt a translatable string.

For example cheeck out https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/filesystem/local/src/Adapter/LocalAdapter.php

avatar laoneo
laoneo - comment - 20 Apr 2022

A basic rule should be that the API throws a specific exception and the representation layer should catch it and display a meaningful error message. We tried to do this in the local adapter with the FileNotFoundException for example. But looks like some slipped through our fingers.

avatar brianteeman
brianteeman - comment - 20 Apr 2022

some? 12/15 is not some

avatar pe7er pe7er - change - 21 Apr 2022
Labels Added: Language Change PBF ?
avatar pe7er
pe7er - comment - 21 Apr 2022

Thanks @brianteeman!

avatar brianteeman
brianteeman - comment - 21 Apr 2022

I have tested this item successfully on 9a915cf

Marking as a successful test as it does what it says. Maintainers can decide if we do want to translate exceptions and then hopefully come up with a plan to update all existing hard coded exception strings.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

avatar brianteeman brianteeman - test_item - 21 Apr 2022 - Tested successfully
avatar pe7er
pe7er - comment - 21 Apr 2022

Thanks. If this PR gets accepted, then I'll fix more of those hard coded Exception errors in components when I find them.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 21 Apr 2022

I have tested this item successfully on 9a915cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 21 Apr 2022

I have tested this item successfully on 9a915cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 21 Apr 2022 - Tested successfully
avatar richard67 richard67 - change - 21 Apr 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

avatar rdeutz rdeutz - change - 21 Apr 2022
Labels Added: ?
Removed: PBF
avatar rdeutz rdeutz - change - 21 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-21 19:51:24
Closed_By rdeutz
avatar rdeutz rdeutz - close - 21 Apr 2022
avatar rdeutz rdeutz - merge - 21 Apr 2022

Add a Comment

Login with GitHub to post a comment