[#37583] - [4.2] Indicate if category not published
- Fixed in Code Base
- 26 Apr 2022
- Medium
- Build: 4.1-dev
- # 37583
- Diff
- brianteeman:check
User tests: Successful: Unsuccessful:
Articles that are in a category which is unpublished or trashed are not visible on the site but there is no way you can tell this from the article manager
Summary of Changes
- Adds an indicator if the category is unpublished or trashed.
- Changes the published icon to a disabled icon and adds a tooltip to the icon
Testing Instructions
Create a catgory called test and create 4 featured articles in that category.
Unpublish or Trash the category
Check the list of articles and the list of featured articles
Actual result BEFORE applying this Pull Request
No indication that the article can not be displayed
Expected result AFTER applying this Pull Request
Text as shown in the image below
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
one addition: maybe better to solve this in the PublishedButton class. Then you only have to fix it one time and not in all views. Could be something like "Published but category unpublished or trashed"
I looked at the class and (beside Workflow, I don't see how this effects the buttom but maybe I missed something) it should be doable. I will check over the weekend and let you know.
This should do the trick: rdeutz@847c041
| Labels |
Added:
?
Maintainers Checked
|
||
| Category | Administration com_content | ⇒ | Administration com_content Language & Strings Libraries |
| Labels |
Added:
Language Change
|
||
one addition: maybe better to solve this in the PublishedButton class. Then you only have to fix it one time and not in all views. Could be something like "Published but category unpublished or trashed"
as even your code requires a chang in the view I decided to combin the two
I have tested this item
The patch workes exactly as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37583.
I have tested this item
Tested in Joomla 4.1.3-dev with PHP 8.1.
Expected behaviour when category is unpublished or trashed.
It works in Featured Articles list too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37583.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37583.
I really like this PR, but it will not make it in 4.1, but for sure in 4.2!
Thanks for the improvement.
| Labels |
Added:
?
|
||
| Category | Administration com_content Language & Strings Libraries | ⇒ | Unit Tests Administration com_cache com_config com_contact com_content com_finder com_languages com_media com_menus com_redirect com_templates com_users Language & Strings Modules |
| Title |
|
||||||
JFYI: the "too much files" will be fixed on Tuesday, then there will be the next upmerge from 4.1 (which is already in your branch) after the relese of J! 4.2 Alpha 2. Then we're back to normal (no additional human tests needed).
No problem
| Labels |
Added:
?
?
Removed: ? |
||
| Category | Administration com_content Language & Strings Unit Tests com_cache com_config com_contact com_finder com_languages com_media com_menus com_redirect com_templates com_users Modules | ⇒ | Administration com_content Language & Strings Libraries |
| Labels |
Removed:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-26 19:16:32 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
Looks like a good idea, I think this is something we should add and can be added to the next minor version.