Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37578] - [4.1] Filter on category state for Tags module (Part: frontend fix)

? ? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
19 Apr 2022

Pull Request for Issue #37577 .

Summary of Changes

Count only items in published categories in the tags module.

Testing Instructions

  • Create a catgory called test and create 4 articles in that category.
  • Add a tag to each article
  • Create a module to display popular tags and counts
  • Unpublish or Trash the category

Bonus points for testing other items types like Contract, Newfeeds, ....

Actual result BEFORE applying this Pull Request

Unpublish or Trash a category doesnt't has an effect on the counter in the tag module

Expected result AFTER applying this Pull Request

Unpublish or Trash a category has an effect on the counter in the tag module

avatar rdeutz rdeutz - open - 19 Apr 2022
avatar rdeutz rdeutz - change - 19 Apr 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2022
Category ⇒ Modules Front End
avatar rdeutz rdeutz - change - 19 Apr 2022
Labels Added: ?
avatar rdeutz rdeutz - change - 19 Apr 2022
Title
…
filter on category state
[4.1] Filter on category state for Tags module
avatar rdeutz rdeutz - edited - 19 Apr 2022
avatar brianteeman
brianteeman - comment - 19 Apr 2022

I have tested this item ✅ successfully on 7934927

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37578.

avatar brianteeman brianteeman - test_item - 19 Apr 2022 - Tested successfully
avatar richard67
richard67 - comment - 19 Apr 2022

@rdeutz It solves only a part of the issue, right? If yes, then it would be good to mention that in the description e.g. by adding a " (part)" at the end of the "Pull Request for Issue #37577".

avatar rdeutz
rdeutz - comment - 20 Apr 2022

@richard67 it solves the problem for the frontend and number are correct after the patch. We can do more ofc but I would create another PR for it.

avatar richard67
richard67 - comment - 20 Apr 2022

@rdeutz Then I would really suggest to add something like "(part)" to the line at the top of this PR's description which refers to the issue so no JBS member or maintainer thinks they can close the issue because solved by this PR.

avatar rdeutz rdeutz - change - 20 Apr 2022
Title
…
[4.1] Filter on category state for Tags module
[4.1] Filter on category state for Tags module (Part: frontend fix)
avatar rdeutz rdeutz - edited - 20 Apr 2022
avatar MacJoom
MacJoom - comment - 14 May 2022

I have not tested this item.

also tested newsfeeds with separate tags successfully

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37578.

avatar MacJoom MacJoom - test_item - 14 May 2022 - Not tested
avatar MacJoom
MacJoom - comment - 14 May 2022

I have tested this item ✅ successfully on 32ef4b7

also tested newsfeeds with separate tags successfully

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37578.

avatar MacJoom MacJoom - test_item - 14 May 2022 - Tested successfully
avatar alikon
alikon - comment - 14 May 2022

I have tested this item ✅ successfully on 32ef4b7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37578.

avatar alikon alikon - test_item - 14 May 2022 - Tested successfully
avatar alikon alikon - change - 14 May 2022
Status Pending ⇒ Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 14 May 2022
avatar alikon
alikon - comment - 14 May 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37578.

avatar laoneo laoneo - change - 16 May 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 17 May 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-05-17 18:58:00
Closed_By ⇒ bembelimen
avatar bembelimen bembelimen - close - 17 May 2022
avatar bembelimen bembelimen - merge - 17 May 2022
avatar bembelimen
bembelimen - comment - 17 May 2022

Thx

Add a Comment

Login with GitHub to post a comment