[#37564] - [4.1] Unnecessary description for layout
- Fixed in Code Base
- 25 Apr 2022
- Medium
- Build: 4.1-dev
- # 37564
- Diff
- Kostelano:4-1-layout-desc
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In 95% of modules for the control panel, the description for the LAYOUT parameter was previously removed.
The PR removes the last 2.
In the "Login Support Information" module, the "Automatic Title" parameter has been moved 1 param lower, as it corresponds to the position in the other modules.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules |
@HLeithner, so will it be right (copy/paste from 3.10)?
; Deprecated, will be removed with 5.0. Please do not translate the following language string
Please NO
Please NO
Be specific. What exactly is NO?
please no for marking it as deprecated
please no for marking it as deprecated
what else would you like to do with the string?
if its not being used then remove it. which is exactly whats happened to date in j4
if its not being used then remove it. which is exactly whats happened to date in j4
6.1.6 Language keys
Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.
| Labels |
Added:
Language Change
?
|
||
I changed the PR as requested above. Although, of course, it is strange to apply rule 6.1.6 only to some PRs.
Considering that 3.x modules could theoretically work on 4.x, which uses a lot of _DESC strings (including this one), it would probably be more correct.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-25 08:06:15 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Removed:
?
|
||
Thanks!
Please deprecate the language string and don't remove it please