? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Apr 2022

This pr checks if workflows is enable and if it is changes the "featured status" to not display the Toggle message which is incorrect as it is disabled

Pull Request for Issue #34502 .

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar brianteeman brianteeman - open - 15 Apr 2022
avatar brianteeman brianteeman - change - 15 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2022
Category Libraries
avatar brianteeman brianteeman - change - 15 Apr 2022
Labels Added: ?
b5d2fa7 15 Apr 2022 avatar brianteeman cs
avatar Kostelano
Kostelano - comment - 16 Apr 2022

I have tested this item successfully on b5d2fa7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561.

avatar Kostelano Kostelano - test_item - 16 Apr 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 16 Apr 2022

Works as it should.

I note that the problem is solved for favorites, but a similar problem for the state of the publication. With the workflow enabled, there is still a line telling you to click to toggle, but there is no clickability in the workflow for these icons.

Screenshot_1

avatar brianteeman
brianteeman - comment - 16 Apr 2022

please create a neew issue for that

avatar Quy
Quy - comment - 16 Apr 2022

I have tested this item successfully on b5d2fa7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561.

avatar Quy Quy - change - 16 Apr 2022
Status Pending Ready to Commit
avatar Quy Quy - test_item - 16 Apr 2022 - Tested successfully
avatar Quy
Quy - comment - 16 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561.

avatar laoneo laoneo - change - 20 Apr 2022
Status Ready to Commit Pending
avatar laoneo
laoneo - comment - 20 Apr 2022

Back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561.

avatar laoneo
laoneo - comment - 20 Apr 2022

@brianteeman do you have any intention to pass the component to the button?

avatar brianteeman
brianteeman - comment - 20 Apr 2022

no

avatar laoneo laoneo - change - 20 Apr 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-04-20 06:42:23
Closed_By laoneo
avatar laoneo
laoneo - comment - 20 Apr 2022

Ok, then I'm closing this one because of the reasons stated above and will reopen the issue. Thanks for your understanding.

avatar laoneo laoneo - close - 20 Apr 2022
avatar brianteeman
brianteeman - comment - 20 Apr 2022

in another year perhaps someone will look at it again

Add a Comment

Login with GitHub to post a comment