[#37538] - Show loading view in installer component properly
- Closed
- 17 Apr 2022
- Medium
- Build: 4.2-dev
- # 37538
- Diff
- MagnusSinger:i37516
User tests: Successful: Unsuccessful:
Pull Request for Issue #37516
Summary of Changes
When removing the "hidden" class from the loading view in the installer component in the inspector, this view is now properly positioned
Testing Instructions
Go to the extension installer, open the inspector and search for the div with the ID "loading", then remove the "hidden" class from it
Actual result BEFORE applying this Pull Request
The loading view was positioned below the main content and was invisible
Expected result AFTER applying this Pull Request
The loading view is now visible and properly positioned
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37538.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37538.
@MagnusSinger Any reason why this hasn't been made for the 4.2-dev branch and not the 4.1-dev branch? As far as I can see it's a bug fix and not a new feature, so no reason to wait until 4.2.
@richard67 you're right, I'll rebase
| Labels |
Added:
?
|
||
| Category | JavaScript Repository NPM Change | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
@MagnusSinger Something went wrong with the rebase because now the PR shows on GitHub all changes from 4.1-dev to 4.2-dev, too, in addition to your changes. But when trying to fix that here locally on the command line, git tells me your branch is ok and up to date with 4.1-dev.
@MagnusSinger Maybe it would help to locally make a hard reset of the branch to the initial commit for your change, i.e. commit 7673f83 , so that all the later "merge branch 4.2-dev into branch i37516" would be dropped, and then force push to your remote (origin). Shall I try that for you?
Oh yes that would be great, thanks
@MagnusSinger Unfortunately that didn't work. Have you uses the GitHub UI here to change the base branch by using the "Edit" button as if you wanted to edit the title, and then selected the branch and saved? Or have you used a local git client to rebase? Maybe it helps to toggle the branch again here on GitHub, i.e. Edit and change base to 4.2-dev and then again back to 4.1-dev?
Yes, I used the GitHub UI. Let me try changing it once more
| Labels |
Added:
?
?
Removed: NPM Resource Changed ? |
||
| Category | Repository Unit Tests Administration com_admin SQL Postgresql | ⇒ | Administration com_content JavaScript Repository NPM Change External Library Composer Change Front End Plugins |
Okay this somehow didn't work, I'll try to change it locally
@MagnusSinger If nothing else helps, make a new PR ... will test again then.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37538.
@richard67 I created a new PR with base 4.1-dev: #37570
@MagnusSinger Then close this one here with an appropriate comment referring to the new one.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-17 13:10:27 |
| Closed_By | ⇒ | MagnusSinger | |
| Labels |
Removed:
?
|
||
| Category | Repository Administration com_content JavaScript NPM Change External Library Composer Change Front End Plugins | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
I have tested this item✅ successfully on 063c3e6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37538.