Feeling Lucky
?
?
[#37534] - [4.2] Installation updateuserids
- Fixed in Code Base
- 4 Jul 2022
- Medium
- Build: 4.1-dev
- # 37534
- Diff
- brianteeman:patch-3
User tests: Successful: Unsuccessful:
Summary of Changes
during the installation we run various queries to update default data with the superuseerid created during the install
Testing Instructions
Clean install from the generated full package
Check that you never get an error message
Actual result BEFORE applying this Pull Request
Running queries on tables that have no data
Expected result AFTER applying this Pull Request
No change to the generated install
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Title |
|
||||||
| Labels |
Added:
?
|
||
brianteeman
- comment
- 22 Jun 2022
rebased to 4,2 now that there will be no further 4.1 releases
joomla-bot
- comment
- 27 Jun 2022
This pull requests has been automatically converted to the PSR-12 coding standard.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-04 11:06:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
Removed: ? |
||
wilsonge
- comment
- 4 Jul 2022
This is clearly correct given the change in sample data in J4 and given it's not getting tests choosing to merge this on review.
brianteeman
- comment
- 4 Jul 2022
Thanks
In 3.10 the removed entries might be needed because one can chose to install sample data at the end of a new installation. But on 4.1 these entries seem to be not needed because the tables are empty after a new installation. So by review this PR seems to be right.