[#37531] - [4.1] Fix title by contact save to menu
- Fixed in Code Base
- 12 Apr 2022
- Medium
- Build: 4.1-dev
- # 37531
- Diff
- heelc29:issue-contact-save2menu
User tests: Successful: Unsuccessful:
Summary of Changes
contact object has no title property (only name)
Testing Instructions
Create/Open a contact and click Save to Menu
Actual result BEFORE applying this Pull Request
Menu item title is empty
PHP Warning: Undefined property: Joomla\CMS\Object\CMSObject::$title in administrator\components\com_contact\src\Controller\ContactController.php on line 137
Expected result AFTER applying this Pull Request
Menu item title is name of contact
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
That is wrong, the title of the menu doesn't neccessary has to be the name of the contact. When you create a contact and save it to menu, a menu edit form opens and you can enter whatever you want as title.
@drmenzelit Ok. Then we have to remove the line 137 (s. PHP warning)??
Note: If you do the same (save2menu) for an article, the default menu item title is the title of the article. It is only the suggest for the title and you can adjust it before you save the menu item.
I undertand what you mean now. In articles the field containing the name of the name is called "title", but in contact the field is called "name". Then your PR could be correct. I will wait for other opinions.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37531.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37531.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37531.
Quy
- | Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-12 01:22:22 |
| Closed_By | ⇒ | bembelimen |
Thx
That is wrong, the title of the menu doesn't neccessary has to be the name of the contact. When you create a contact and save it to menu, a menu edit form opens and you can enter whatever you want as title.