Feeling Lucky
?
Release Blocker
?
[#37528] - Fix empty state buttons in discover and update
- Fixed in Code Base
- 11 Apr 2022
- Medium
- Build: 4.1-dev
- # 37528
- Diff
- chmst:discover-update-emptystate-buttons
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fix warning with empty state buttons in joomla update and discover. Changed the controller with checkToken('request').
These buttons are originally createButtons and it is a kind of misuse here. But better notto change the layout for users.
So I am closing this one: #37526
Testing Instructions
Use an application where is nothing to discover, Go to system-discover or joomla updtat and activate the button
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No warning.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_joomlaupdate |
| Title |
|
||||||
| Labels |
Added:
?
|
||
chmst
- comment
- 10 Apr 2022
Thanks - changed the controllers again. Could you repeat your test, please?
ChristineWk
- comment
- 10 Apr 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37528.
khu5h1
- comment
- 10 Apr 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37528.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 11 Apr 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37528.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-11 12:51:57 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
Release Blocker
|
||
bembelimen
- comment
- 11 Apr 2022
Thx
It was successful, but when I click Discover in the top left, the error message appears again
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37528.