? Language Change ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Apr 2022

Change the link with long text that is apparently confusing people to shorter text that is styled like a button

Pull Request for Issue #37512 .

After

image

avatar brianteeman brianteeman - open - 8 Apr 2022
avatar brianteeman brianteeman - change - 8 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2022
Category Administration com_joomlaupdate Language & Strings
avatar laoneo
laoneo - comment - 8 Apr 2022

Is there a reason this button should not be inline and the same size with the other two ones?

avatar brianteeman
brianteeman - comment - 8 Apr 2022

yes absolutely. its not a preferred option hence it is smaller and below. just as the link text was before

avatar brianteeman brianteeman - change - 8 Apr 2022
Labels Added: Language Change ?
avatar toivo
toivo - comment - 8 Apr 2022

I have tested this item successfully on 2718226

Tested successfully in Joomla 4.2.3-dev of 8 April in Wampserver 3.2.7 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

avatar toivo toivo - test_item - 8 Apr 2022 - Tested successfully
avatar Webdongle
Webdongle - comment - 8 Apr 2022

I have tested this item successfully on 2718226

Success


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

avatar Webdongle Webdongle - test_item - 8 Apr 2022 - Tested successfully
avatar alikon alikon - change - 8 Apr 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 8 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

avatar Kostelano
Kostelano - comment - 8 Apr 2022

I am not a designer, I look at the result as a normal user. It looks terrible.
The string option was better.

avatar laoneo
laoneo - comment - 9 Apr 2022

Adding here the RLDQ label.

avatar toivo
toivo - comment - 9 Apr 2022

ReleasLeadDecisionQueue because of one opinion to the contrary?

The word 'msnually' does not belong to the string. It causes confusion and it needs to go.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

avatar Kostelano
Kostelano - comment - 10 Apr 2022

Just for thought. Why not put "Upload and Install" and "Reinstall" buttons in the toolbar? How do I get into the menu for reinstalling kernel files now? I can not.

Screenshot_1

avatar Webdongle
Webdongle - comment - 10 Apr 2022

Just for thought. Why not put "Upload and Install" and "Reinstall" buttons in the toolbar? How do I get into the menu for reinstalling kernel files now? I can not.

That is a different issue.
btw
reinstall 01

Although tabs like in J3 would imho be better. But the powers that be decided on this design. Anyway it is the wording itself this is dealing with. If you want to change the layout start another tracker and create a patch for that.

avatar simbus82
simbus82 - comment - 11 Apr 2022

I am not a designer, I look at the result as a normal user. It looks terrible. The string option was better.

We are de facto in a "admin management app", for a good UX actions need to be identified by buttons.
A linked text is wrong in this type of UI, this isn't a webpage. (for example, it would make more sense to refer to an external page of the guide as linked text and not as a button).

avatar Kostelano
Kostelano - comment - 11 Apr 2022

@simbus82
It doesn't matter to me - a button or a line - both can be a good solution, BUT. I'm talking about the fact that THIS visual solution loses to the original version. Perhaps if the button could be implemented in the same size/style, and also placed in a better place (it's hard for me to think of a better one, except for, for example, a toolbar), this would be a better solution.

In any case, the decision is up to the maintainers.

avatar Webdongle
Webdongle - comment - 11 Apr 2022

@Kostelano
The position is in the same place as the incorrect text was. The size of the button balances the page. But it is not about the position it is about the fact that the wording needs to be changed to 'Upload and Update'. Please stop derailing this thread by making off topic comments. If you want the position changed please start another separate tracker.

avatar bembelimen
bembelimen - comment - 26 Apr 2022

I'm ok with the button but I have some doubts about the text. Probably it's a thing as I'm not a native speaker, but I'm missing the "what should I upload" information.

"Update by uploading the update package"

Something like that (although I'm still not 100% happy)?

avatar brianteeman
brianteeman - comment - 26 Apr 2022

It's the text that's causing the problems

avatar brianteeman
brianteeman - comment - 26 Apr 2022

All that information is on the next page

image

avatar Webdongle
Webdongle - comment - 26 Apr 2022

@bembelimen
'Upload and Update' is the wording that has been used for at least 7 years. Why wait until now to object to it's use?

'Upload and Update' is also used in the helpscreen linked to from the Component
https://help.joomla.org/proxy?keyref=Help41:Joomla_Update#Upload_and_Update
"You can use this feature to update Joomla if your server is behind a firewall or otherwise unable to contact the update servers. First download the Joomla Upgrade Package in ZIP format from the official Joomla download page."

avatar bembelimen
bembelimen - comment - 30 Apr 2022

All that information is on the next page

image

Fair enough, just we shouldn't remove existing language strings then I'm ok.

avatar brianteeman brianteeman - change - 30 Apr 2022
Labels Added: ? ?
d66417f 30 Apr 2022 avatar brianteeman .
avatar brianteeman
brianteeman - comment - 30 Apr 2022

Fair enough, just we shouldn't remove existing language strings then I'm ok.

I really disagree with keeping unused strings for core components. It makes no logical seense to me at all so to move this forward I have changed this pr to keep the strings with the new values

avatar bembelimen
bembelimen - comment - 1 May 2022

Not many rules, it's in the B/C promise... Thx

avatar brianteeman
brianteeman - comment - 1 May 2022

Not many rules, it's in the B/C promise... Thx

Doesn't mean it makes sense ;)

avatar bembelimen bembelimen - change - 1 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-01 11:25:29
Closed_By bembelimen
avatar bembelimen bembelimen - close - 1 May 2022
avatar bembelimen bembelimen - merge - 1 May 2022
avatar bembelimen
bembelimen - comment - 1 May 2022

Thx

avatar brianteeman
brianteeman - comment - 1 May 2022

thanks - got there in the end

avatar toivo
toivo - comment - 1 May 2022

Thank you everyone!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

avatar Webdongle
Webdongle - comment - 1 May 2022

Thank you especially @brianteeman

Add a Comment

Login with GitHub to post a comment