Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
8 Apr 2022

related to #37449 .

Summary of Changes

add the option to add Scheduler to System Quick icons

Testing Instructions

apply patch
edit admin module System Quick icon
set Scheduler Icon to show

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

image

avatar alikon alikon - open - 8 Apr 2022
avatar alikon alikon - change - 8 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2022
Category Administration Language & Strings Modules
avatar brianteeman
brianteeman - comment - 8 Apr 2022

There is a PR that adds the ability to add more icons etc. Probably better to update that one.

avatar simbus82
simbus82 - comment - 8 Apr 2022

First I wanted to ask why making another option, but then I saw all the other icons are options as well. I really don't like these hard wires between extensions and on some point we need to make plugins out of them as there is an event for this already. But approving it for now.

I also don't like a lot this UI from UX perspective. But at the moment the @alikon solution follows this track.

Probably there should be some multiple selector or/with repeatable fields that gives us the maximum freedom to manage what icons we want to show, proposing lists of extensions, modules and plugins active in the cms. Not a fixed and predetermined (by who?) list of "show / hide" selectors.

avatar brianteeman
brianteeman - comment - 8 Apr 2022

Please see #32671

avatar alikon alikon - change - 8 Apr 2022
Labels Added: Language Change ?
avatar alikon
alikon - comment - 8 Apr 2022

folks the goal of this pr is not to change the current quick icons behaviuor, but to have a 1 click less way to go to the scheduler

avatar brianteeman
brianteeman - comment - 8 Apr 2022

folks the goal of this pr is not to change the current quick icons behaviuor, but to have a 1 click less way to go to the scheduler

so do it for everything not just this one

avatar alikon
alikon - comment - 8 Apr 2022

it's out of the scope of this pr

avatar simbus82
simbus82 - comment - 8 Apr 2022

I have tested this item successfully on 19a430f

image

Tested on Joomla 4.1.2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37513.

avatar simbus82 simbus82 - test_item - 8 Apr 2022 - Tested successfully
avatar brcodes
brcodes - comment - 8 Apr 2022

I have tested this item successfully on 19a430f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37513.

avatar brcodes brcodes - test_item - 8 Apr 2022 - Tested successfully
avatar richard67 richard67 - change - 8 Apr 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 8 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37513.

avatar brianteeman
brianteeman - comment - 8 Apr 2022

I am not in favour of this change. Instead #32671 should be used - do it once and do it right

avatar richard67
richard67 - comment - 8 Apr 2022

I am not in favour of this change. Instead #32671 should be used - do it once and do it right

It seems that PR is not ready anymore since it has conflicts.

avatar brianteeman
brianteeman - comment - 8 Apr 2022

@richard67 it is still the right way forward

avatar richard67
richard67 - comment - 8 Apr 2022

@richard67 it is still the right way forward

But it doesn’t add anything for the scheduler, does it?

avatar brianteeman
brianteeman - comment - 8 Apr 2022

only because the scheduler didnt exist at the time.

my point is that we should do this once for everything

avatar brianteeman
brianteeman - comment - 8 Apr 2022

i will spend some time in the weekend to update that pr

avatar chmst
chmst - comment - 8 Apr 2022

I had it on my to do list but I think the quickicon module should be re-worked completely, enabling individual sorting and own classes for icons and better params. I see this PR as a quick improvement promoting the scheduled task feature.

avatar laoneo
laoneo - comment - 9 Apr 2022

As this is a new feature it should be added to 4.2 anyway. @alikon can you please rebase the branch. I would not invest more time into it, when other pr's will come up with an improved quickicon architecture, then we should go that way then. On a long term adding more and more options to the module is not sustainable.

avatar laoneo laoneo - change - 9 Apr 2022
Status Ready to Commit Pending
avatar laoneo
laoneo - comment - 9 Apr 2022

Pack to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37513.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2022
Category Administration Language & Strings Modules Unit Tests SQL Administration com_admin Postgresql Language & Strings Modules Installation
avatar alikon alikon - change - 9 Apr 2022
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2022
Category Administration Language & Strings Modules Unit Tests SQL com_admin Postgresql Installation Unit Tests Administration Language & Strings Modules SQL Installation Postgresql
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2022
Category Administration Language & Strings Modules Unit Tests SQL Postgresql Installation Administration Language & Strings Modules SQL Installation Postgresql
avatar alikon alikon - change - 9 Apr 2022
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2022
Category Administration Language & Strings Modules SQL Postgresql Installation Administration Language & Strings Modules
avatar alikon alikon - change - 9 Apr 2022
Title
[4] add scheduler to System Quick icons
[4.2] add scheduler to System Quick icons
avatar alikon alikon - edited - 9 Apr 2022
avatar richard67
richard67 - comment - 9 Apr 2022

@alikon Hmm, what you are doing now after the rebase, deleting and creating again files, will mess up the history of these files when your PR will be merged one day. So maybe it would be better just to re-do it with a new PR?

Besides this, @brianteeman wrote that he wants to come up with a better solution this weekend. Maybe wait for that so you don't waste more time here?

avatar alikon
alikon - comment - 9 Apr 2022

i've made mistakes in rebase...anyway
let's close then

avatar alikon alikon - change - 9 Apr 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-04-09 10:17:40
Closed_By alikon
Labels Removed: ?
avatar alikon alikon - close - 9 Apr 2022
avatar richard67
richard67 - comment - 9 Apr 2022

Rebase is not easy when the 4.2-dev branch is behind the 4.1-dev branch regarding commits and a PR was created after the point of time when the 4.2-dev branch was up to date with the 4.1-dev commits so that the PR after the rebase is in advance to the 4.2-dev branch with these commits. Then GitHub shows not only the changes from that PR but also those from the 4.1-dev branch which have not been merged up into 4.2-dev yet.

The easiest way to avoid is is to wait with a rebase of the PR until the next upmerge from 4.1-dev to 4.2-dev has happened.

avatar brianteeman
brianteeman - comment - 9 Apr 2022

My gut feeling is that the correct way forward is to make this a quickicon plugin and then convert the existing module to also be individual plugins and then add new plugins for the missinf quickicons

Add a Comment

Login with GitHub to post a comment