User tests: Successful: Unsuccessful:
related to #37449 .
add the option to add Scheduler to System Quick icons
apply patch
edit admin module System Quick icon
set Scheduler Icon to show
N/A
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Modules |
First I wanted to ask why making another option, but then I saw all the other icons are options as well. I really don't like these hard wires between extensions and on some point we need to make plugins out of them as there is an event for this already. But approving it for now.
I also don't like a lot this UI from UX perspective. But at the moment the @alikon solution follows this track.
Probably there should be some multiple selector or/with repeatable fields that gives us the maximum freedom to manage what icons we want to show, proposing lists of extensions, modules and plugins active in the cms. Not a fixed and predetermined (by who?) list of "show / hide" selectors.
Labels |
Added:
Language Change
?
|
folks the goal of this pr is not to change the current quick icons behaviuor, but to have a 1 click less way to go to the scheduler
folks the goal of this pr is not to change the current quick icons behaviuor, but to have a 1 click less way to go to the scheduler
so do it for everything not just this one
it's out of the scope of this pr
I have tested this item
Tested on Joomla 4.1.2
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
@richard67 it is still the right way forward
@richard67 it is still the right way forward
But it doesn’t add anything for the scheduler, does it?
only because the scheduler didnt exist at the time.
my point is that we should do this once for everything
i will spend some time in the weekend to update that pr
I had it on my to do list but I think the quickicon module should be re-worked completely, enabling individual sorting and own classes for icons and better params. I see this PR as a quick improvement promoting the scheduled task feature.
As this is a new feature it should be added to 4.2 anyway. @alikon can you please rebase the branch. I would not invest more time into it, when other pr's will come up with an improved quickicon architecture, then we should go that way then. On a long term adding more and more options to the module is not sustainable.
Status | Ready to Commit | ⇒ | Pending |
Pack to pending
Category | Administration Language & Strings Modules | ⇒ | Unit Tests SQL Administration com_admin Postgresql Language & Strings Modules Installation |
Labels |
Added:
?
?
|
Category | Administration Language & Strings Modules Unit Tests SQL com_admin Postgresql Installation | ⇒ | Unit Tests Administration Language & Strings Modules SQL Installation Postgresql |
Category | Administration Language & Strings Modules Unit Tests SQL Postgresql Installation | ⇒ | Administration Language & Strings Modules SQL Installation Postgresql |
Labels |
Removed:
?
|
Category | Administration Language & Strings Modules SQL Postgresql Installation | ⇒ | Administration Language & Strings Modules |
Title |
|
@alikon Hmm, what you are doing now after the rebase, deleting and creating again files, will mess up the history of these files when your PR will be merged one day. So maybe it would be better just to re-do it with a new PR?
Besides this, @brianteeman wrote that he wants to come up with a better solution this weekend. Maybe wait for that so you don't waste more time here?
i've made mistakes in rebase...anyway
let's close then
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-09 10:17:40 |
Closed_By | ⇒ | alikon | |
Labels |
Removed:
?
|
Rebase is not easy when the 4.2-dev branch is behind the 4.1-dev branch regarding commits and a PR was created after the point of time when the 4.2-dev branch was up to date with the 4.1-dev commits so that the PR after the rebase is in advance to the 4.2-dev branch with these commits. Then GitHub shows not only the changes from that PR but also those from the 4.1-dev branch which have not been merged up into 4.2-dev yet.
The easiest way to avoid is is to wait with a rebase of the PR until the next upmerge from 4.1-dev to 4.2-dev has happened.
My gut feeling is that the correct way forward is to make this a quickicon plugin and then convert the existing module to also be individual plugins and then add new plugins for the missinf quickicons
There is a PR that adds the ability to add more icons etc. Probably better to update that one.