[#37483] - [4.1] incorrect role on language switcher
- Fixed in Code Base
- 4 Apr 2022
- Medium
- Build: 4.1-dev
- # 37483
- Diff
- brianteeman:mod-lang
User tests: Successful: Unsuccessful:
Pull Request for Issue #37479 .
Testing Instructions
Make sure that you test all the variants of the module
the role that was not needed is only for use when you have non-list elements eg div that you want to behave like a select option. you cant apply that to an existing list.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item
I tested with Lighthouse on Chrome: 100% in accessibility (84% before this patch) and with IBM Equal Access Accessibility Checker: the error I had before (Violation: The element with role "option" is not contained in or owned by an element with one of the following roles: "group, listbox") is now gone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37483.
I have tested this item
I tested with Lighthouse on Chrome: 100% in accessibility (84% before this patch) and with IBM Equal Access Accessibility Checker: the error I had before (Violation: The element with role "option" is not contained in or owned by an element with one of the following roles: "group, listbox") is now gone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37483.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37483.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-04 16:28:14 |
| Closed_By | ⇒ | Quy |
Thank you!
I have tested this item✅ successfully on a2a06de
Tested successfully on 4.1.2 with Cassiopeia and two languages.
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37483.