? Language Change PBF ? Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
4 Apr 2022

Summary of Changes

add target=_blank and rel=noopener noreferrer for external links

Testing Instructions

Clicking on the links opens the target in a new window and "noopener noreferrer" is passed as rel values.

Actual result BEFORE applying this Pull Request

A link does not open in a new window.
Both links have no rel values.

Expected result AFTER applying this Pull Request

target=\"_blank\" rel=\"noopener noreferrer\" for external links

Documentation Changes Required

.

avatar tecpromotion tecpromotion - open - 4 Apr 2022
avatar tecpromotion tecpromotion - change - 4 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2022
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 4 Apr 2022

originally we did not add rel= to these links as it was felt that we could trut our own web sites

avatar tecpromotion
tecpromotion - comment - 4 Apr 2022

originally we did not add rel= to these links as it was felt that we could trut our own web sites

There are currently 11 links to https://docs.joomla.org in use like this.
I would be happy if we could standardise this.

avatar simbus82
simbus82 - comment - 4 Apr 2022

originally we did not add rel= to these links as it was felt that we could trut our own web sites

Anyway It's a best practice to use Noopener for linking external sites. The "noopener" attribute ensures that the page opened in a new tab cannot take control of the original page (Reverse Tabnabbing attack). It is useful for both safety and performance and you never know what can happen...
I have some doubts about the use of the noreferrer, in fact the only effect is that the analytics of the joomla sites would see direct traffic instead of referral traffic.
Using it maybe allows us to say that Joomla.org does not read any data from the Joomla installed (without the noreferrer if I click on those links, the Joomla.org analytics sees my domain inside the referrer).

avatar kiki-G
kiki-G - comment - 22 Apr 2022

I have tested this item successfully on 302fe4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475.

avatar kiki-G kiki-G - test_item - 22 Apr 2022 - Tested successfully
avatar kiki-G kiki-G - test_item - 22 Apr 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 22 Apr 2022

I have tested this item successfully on 302fe4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475.

avatar RickR2H RickR2H - test_item - 22 Apr 2022 - Tested successfully
avatar RickR2H RickR2H - change - 22 Apr 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 22 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475.

avatar laoneo laoneo - change - 23 Apr 2022
Labels Added: ? Language Change PBF ?
avatar laoneo laoneo - change - 23 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-23 11:17:21
Closed_By laoneo
avatar laoneo laoneo - close - 23 Apr 2022
avatar laoneo laoneo - merge - 23 Apr 2022
avatar laoneo
laoneo - comment - 23 Apr 2022

Thanks!

Add a Comment

Login with GitHub to post a comment