? ? Pending

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
2 Apr 2022

Summary of Changes

Something broke the SELECT * query, resulting in a NULL id when
it was finally evaluated against the DB in TasksModel. This broke
the scheduler:run console command which is fixed by this commit.

Testing Instructions

  • Create a scheduled task.
  • Trigger the scheduler from the CLI: php joomla.php scheduler:run.

Actual result BEFORE applying this Pull Request

Run tasks
=========


In OptionsResolver.php line 1060:

  The option "id" with value null is expected to be of type "numeric", but is of type "null".

Expected result AFTER applying this Pull Request

Run tasks
=========

Task#02 'Some Task' processed in 5.12 seconds.

Finished running 1 tasks in 5.12 seconds.

Documentation Changes Required

None

avatar ditsuke ditsuke - open - 2 Apr 2022
avatar ditsuke ditsuke - change - 2 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2022
Category Administration
avatar ditsuke ditsuke - change - 2 Apr 2022
Title
Fix DB query in Scheduler::getTaskRecords()
[4.1-dev] Fix DB query in Scheduler::getTaskRecords()
avatar ditsuke ditsuke - edited - 2 Apr 2022
avatar ditsuke
ditsuke - comment - 2 Apr 2022
avatar ditsuke ditsuke - change - 2 Apr 2022
Title
[4.1-dev] Fix DB query in Scheduler::getTaskRecords()
[4.1-dev] Fix DB query in `Scheduler::getTaskRecords()`
avatar ditsuke ditsuke - edited - 2 Apr 2022
avatar bembelimen bembelimen - change - 3 Apr 2022
Labels Added: ?
avatar richard67
richard67 - comment - 3 Apr 2022

I have tested this item successfully on 93dd1d6

Works with MySQL as well as with PostgreSQL.

Hint for other testers: The error fixed by this PR only happens when the task needs to run. I.e. if the task is scheduled to run every 5 minutes, it might take up to 5 minutes until you get the error for the first time, and then again 5 minutes until next time. In between, when the task doesn't need to be run, you get a "No tasks due!" message without and with this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37463.

avatar richard67 richard67 - test_item - 3 Apr 2022 - Tested successfully
avatar Quy
Quy - comment - 3 Apr 2022

I have tested this item successfully on 93dd1d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37463.

avatar Quy Quy - test_item - 3 Apr 2022 - Tested successfully
avatar Quy Quy - change - 3 Apr 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37463.

avatar Quy Quy - change - 3 Apr 2022
Labels Added: ?
avatar laoneo laoneo - close - 4 Apr 2022
avatar laoneo laoneo - merge - 4 Apr 2022
avatar laoneo laoneo - change - 4 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-04 11:11:25
Closed_By laoneo
avatar laoneo
laoneo - comment - 4 Apr 2022

Thanks!

avatar ditsuke
ditsuke - comment - 5 Apr 2022

Thanks!

Add a Comment

Login with GitHub to post a comment