[#37450] - [4.1][bug] Restore image
- Fixed in Code Base
- 4 Apr 2022
- Medium
- Build: 4.1-dev
- # 37450
- Diff
- dgrammatiko:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue #37448 .
Summary of Changes
Use the right variable
Testing Instructions
Check that finder has images
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
| Labels |
Added:
?
|
||
Not sure with my test result since this PR fixes that images were not shown at all, and fixing the other thing (option not respected) is another issue and should be fixed separately. But maybe we can fix it here?
I think I found it. It was also broken by PR #37022 . Before that PR, variable $image was only set when $showImage was true, so it did not need to check that again in the if condition fixed by this PR. But after the other PR it would need that check. I will make a suggestion in a minute.
I think I found it. It was also broken by PR #37022
Exactly what I reported
@brianteeman Where? I saw your report handles the images never being shown. My comment refers to the option being ignored and the images being always shown when the first issue is fixed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37450.
@brianteeman The PR is fine now. Could you test it, too? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37450.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37450.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-04 07:40:58 |
| Closed_By | ⇒ | laoneo |
Thanks!
Txs for the fix!
One thing that I was wondering though @dgrammatiko : the plugin Responsive Images works automatically a.o. for intro & full images, for images within the articles, even in Custom HTML Modules.
But why doesn't it trigger for the Smart Search Result Page?
Indeed I get
<img src="/images/concerts/bw1.jpg" alt="L'Ombre de Saint-Saëns" width="2000" height="1334" loading="lazy">
and not the full figure/picture element like on the Article page itself
<figure class="item-image">
<picture class="responsive-image"><source type="image/webp" sizes="(max-width: 1920px) 100vw 1920px" srcset="/media/cached-resp-images/images/concerts/bw1_1920.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 1920w, /media/cached-resp-images/images/concerts/bw1_1600.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 1600w, /media/cached-resp-images/images/concerts/bw1_1200.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 1200w, /media/cached-resp-images/images/concerts/bw1_992.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 992w, /media/cached-resp-images/images/concerts/bw1_768.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 768w, /media/cached-resp-images/images/concerts/bw1_480.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 480w, /media/cached-resp-images/images/concerts/bw1_320.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 320w, /media/cached-resp-images/images/concerts/bw1_200.webp?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 200w"><source type="image/jpeg" sizes="(max-width: 1920px) 100vw 1920px" srcset="/media/cached-resp-images/images/concerts/bw1_1920.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 1920w, /media/cached-resp-images/images/concerts/bw1_1600.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 1600w, /media/cached-resp-images/images/concerts/bw1_1200.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 1200w, /media/cached-resp-images/images/concerts/bw1_992.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 992w, /media/cached-resp-images/images/concerts/bw1_768.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 768w, /media/cached-resp-images/images/concerts/bw1_480.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 480w, /media/cached-resp-images/images/concerts/bw1_320.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 320w, /media/cached-resp-images/images/concerts/bw1_200.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730 200w"><img loading="lazy" width="2000" height="1334" src="/media/cached-resp-images/images/concerts/bw1_1920.jpg?version=22e1d71d7cb6fd0e9b7e14fad9ef7730" itemprop="image" alt="L'Ombre de Saint-Saëns"></picture> <figcaption class="caption">© Leslie Artamonow</figcaption>
</figure>
Sure. Here it is: ttc-freebies/plugin-responsive-images#162
I have tested this item? unsuccessfully on 3abe8fd
Images are included in search results when this PR is applied, but the "Result Image" option of the Smart Search component is not respected, i.e. the images are still included when this option has been switched off and the index has been cleared and rebuilt after that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37450.