[#37446] - [4.2] Convert log type field to fancy select
- Fixed in Code Base
- 12 Apr 2022
- Medium
- Build: 4.2-dev
- # 37446
- Diff
- Digital-Peak:j4/actionlog/events
User tests: Successful: Unsuccessful:
Pull Request for Issue #22627 and alternative for #22699.
Summary of Changes
Converts the log type field into a fancy select, so all events can be disabled.
Testing Instructions
- Go to /administrator/index.php?option=com_config&view=component&component=com_actionlogs
- Remove all entries from the "Events To Log" field
- Click save
Actual result BEFORE applying this Pull Request
All elements are selected.
Expected result AFTER applying this Pull Request
None is selected.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
It wuld be even better if it was like
but if its a choice between the current checkboxes and this list I would stick with the checkboxes. Thye might look ugly but they are much easier to use and you can easily see what is selected without accidentally unleselcting everything.
| Labels |
Added:
?
|
||
@Kostelano nice catch. Thanks for the hint. Adapted.
| Category | Administration | ⇒ | Administration Front End Plugins |
I have tested this item
I will note that everything works. But in part I will support Brian - it seems to me that it is logical to have an ALL button in the drop-down list so that all N extensions are not selected and that it is displayed when selecting ALL extensions with a single click. And, for example, when the ALL button is deleted with a cross, the line remains empty, i.e. no component would be selected.
If something similar can be implemented in this PR, it would be great.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
What I do in DPCalendar is that the default option is "All". But then the user can select individual items, but when the all entry is selected beside individual items then "All" wins. That would be a way to go for me.
I am not in favour of this change for the reasons I stated above. Long multiple select lists are terrible for usability. It is far too easy to unselect your current selection when scrolling through the list. We already have a solution for this and we should use it instead of inventing another
Thanks for sharing your opinion.
I have tested this item
fancy-list rocks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
sorry but as you made changes to the code it cannot be rtc and must be retested
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37446.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-12 18:45:38 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
Go to the user profile to the activity log tab, where you can also define a list of extensions for sending notifications.