[#37437] - Fix bug use value 1 as TRUE Workflowcondition Field
- Closed
- 6 Apr 2023
- Medium
- Build: 4.1-dev
- # 37437
- Diff
- korenevskiy:Fix-bug-use-value-1-as-TRUE---Workflowcondition-Field
- Success Download Prebuilt packages are available for download. Details
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Correcting a gross mistake. Obviously, the value 1 of the field attribute is always used equivalent to "TRUE". But this value is not supported by this attribute. We very often use the values "1" or "0" to determine the bool value, and to a small extent use other values. Therefore, to support the value of "1" to determine true, I add this PR.
This field has an important XML attribute "hide_all". The value of this attribute defining the true value is: "true", "yes". But such in these values there is no value of "1". Since these values are the most common value for determining the true value.
<field type="workflowcondition" name="fieldname" hide_all="yes" />I am adding a PR capability to support the true value for the "hide_all" attribute value of "1".
This example will work with PR, and not work without PR.
<field type="workflowcondition" name="fieldname" hide_all="1" />| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
Thanks for the pull request. Unfortunately the testing instructions are missing so we can't reproduce and analyse the issue to decide if we can accept the changes or not. I'm closing the pr and when you have updated the description with proper testing instructions, please reopen it again. Thanks for understanding.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-06 12:08:49 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
?
Removed: ? ? |
||
@korenevskiy could youplease complete your PR with the usual description and Testing instruction?