PBF ? Pending

User tests: Successful: Unsuccessful:

avatar MagnusSinger
MagnusSinger
30 Mar 2022

Pull Request for Issue #37399

Summary of Changes

In the post-installation messages, you can now reset hidden messages before you have to hide all the other messages

Testing Instructions

There's an extra button in the toolbar, hide one message and press the reset button, and the message will be visible again

Actual result BEFORE applying this Pull Request

You had to hide all messages before making them visible again

Expected result AFTER applying this Pull Request

You can show hidden messages again before hiding all others before

Documentation Changes Required

None

avatar MagnusSinger MagnusSinger - open - 30 Mar 2022
avatar MagnusSinger MagnusSinger - change - 30 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2022
Category Administration com_postinstall
avatar MagnusSinger MagnusSinger - change - 30 Mar 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 30 Mar 2022

The reset button should not be displayed (or it should be disabled) if there are no hidden messages.

(I'm not convinced this button is a suitable solution to the issue. As I write in the issue there are several ways to achieve the aim. It all depends on what is the motivation/reason for the change.

avatar chmst
chmst - comment - 30 Mar 2022

Thank you for your contribution, @MagnusSinger!

This indeed solves the acute problem, that a hidden message cannot be reactivated. As you can see in the issue comments, this could be only an interim solution.

avatar MagnusSinger
MagnusSinger - comment - 30 Mar 2022

Yes I'll fix that it only shows the button when messages are hidden later, but I think the solution with the button on top is a bit cleaner than minimizing hidden messages, but I'm open for suggestions

avatar MagnusSinger
MagnusSinger - comment - 30 Mar 2022

@brianteeman I just updated my PR and it shows the button only when there are hidden messages now

avatar Quy
Quy - comment - 11 Apr 2022

Please fix and use the refresh icon instead of plus icon.

security-token

avatar MagnusSinger
MagnusSinger - comment - 12 Apr 2022

@Quy I updated the button

avatar Quy
Quy - comment - 12 Apr 2022

Please also fix the security token warning. Thanks.

avatar MagnusSinger
MagnusSinger - comment - 12 Apr 2022

@Quy I'm sorry but how can I see warnings in the backend? I somehow can't see the warning message

avatar Quy
Quy - comment - 12 Apr 2022

Click the Reset button in the toolbar.

avatar MagnusSinger
MagnusSinger - comment - 12 Apr 2022

When I click on the reset button, there is no warning message, I just re-tried it

avatar Quy
Quy - comment - 12 Apr 2022

Let me try again with the prebuilt package and report back later.

avatar MagnusSinger
MagnusSinger - comment - 12 Apr 2022

Thanks

avatar Quy Quy - change - 14 Jun 2022
Labels Added: PBF
avatar Quy
Quy - comment - 15 Jun 2022

Closing in favor of #38064. Thank you.

avatar Quy Quy - change - 15 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-15 19:44:00
Closed_By Quy
avatar Quy Quy - close - 15 Jun 2022

Add a Comment

Login with GitHub to post a comment