? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
29 Mar 2022

The Appveyor setup was pretty outdated and did rarely any tests. This PR refactors all of this and hopefully improves this for the future. The following changes were done:

  • Updated the system image to run off of from Visual Studio 2015 to Visual Studio 2022
  • Removed the limitations for branches. We haven't had l10n branches for years...
  • Added PHP 8.0 and 8.1 (where 8.1 is allowed to still fail right now)
  • Removed the "caching" of the PHP installation. That stuff never worked. We are always starting with a clean image.
  • Using built in chocolatey instead of downgrading to an earlier version. The bug that required that was fixed a year ago.
  • Removed WinCache setup. First of all, we never ran any tests with WinCache and second of all, WinCache seems to be dead for several years already. I'm going to create PRs to deprecate it for Joomla 5 soon.
  • Removed PostgreSQL. Up till now we didn't run any database tests and Postgres didn't work out of the box in my tests. So for now I've removed that.
  • Added the Integration tests.

These changes mean that while we run 5 jobs instead of 3, it doesn't take longer than before, maybe it is even quicker. This can be merged when the Appveyor tests pass, no tests by humans needed.

avatar Hackwar Hackwar - open - 29 Mar 2022
avatar Hackwar Hackwar - change - 29 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2022
Category Unit Tests
avatar Hackwar Hackwar - change - 29 Mar 2022
Labels Added: ? ?
avatar Hackwar Hackwar - change - 31 Mar 2022
Title
[4.2] Adding PHP 8.0 and 8.1 to appveyor tests
[4.2] Refactoring Appveyor test setup
avatar Hackwar Hackwar - edited - 31 Mar 2022
avatar Hackwar Hackwar - change - 31 Mar 2022
The description was changed
avatar Hackwar Hackwar - edited - 31 Mar 2022
avatar HLeithner
HLeithner - comment - 31 Mar 2022

Any Chance to check hash check for composer? For drone we do this at image build time, but for appveyor you maybe have to do it at runtime

avatar Hackwar
Hackwar - comment - 31 Mar 2022

Uh, I'm pretty sure that we don't actually check the hash of composer... I commented that line... ? However, against what do you want check that hash? Do you want us to update our docker images, etc. each time a new composer is released?

avatar HLeithner
HLeithner - comment - 31 Mar 2022

Uh, I'm pretty sure that we don't actually check the hash of composer... I commented that line... ? However, against what do you want check that hash? Do you want us to update our docker images, etc. each time a new composer is released?

That's what's happening now, weekly builds including hash check of all (current) docker images

avatar Hackwar
Hackwar - comment - 31 Mar 2022

Yeah, don't force me to do this again... Setting this up and making this work was not fun.

avatar HLeithner HLeithner - change - 1 Apr 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-01 13:49:17
Closed_By HLeithner
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - close - 1 Apr 2022
avatar HLeithner HLeithner - merge - 1 Apr 2022
avatar HLeithner
HLeithner - comment - 1 Apr 2022

thanks

avatar laoneo laoneo - change - 1 Apr 2022
Title
[4.2] Refactoring Appveyor test setup
[4.1] Refactoring Appveyor test setup
avatar laoneo laoneo - edited - 1 Apr 2022

Add a Comment

Login with GitHub to post a comment