[#37393] - [4.1] Add text COM_WORKFLOW_STAGE_FORM_NEW to com_workflow.ini
- Fixed in Code Base
- 28 Mar 2022
- Medium
- Build: 4.1-dev
- # 37393
- Diff
- richard67:4.1-dev-workflows-language-strings-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #37390 part 1 .
Summary of Changes
Added the missing language string as discussed in the issue and removed the old one since it is not used anywhere directly or by string concatenation of the key.
Testing Instructions
Edit a workflow stage.
In the edit view, use the action "Save & New".
After that the aria-label of the form should have changed from "Edit Stage" to "Add Stage".
Actual result BEFORE applying this Pull Request
Aria label "COM_WORKFLOW_STAGE_FORM_ADD".
Expected result AFTER applying this Pull Request
Aria label "Add Stage".
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
Language Change
Release Blocker
?
|
||
Can you delete the old string?
On my phone so can't check if it's used elsewhere
@brianteeman Done. As far as I could see it is not used anywhere else directly or for building it by concatenation.
But I still don't find where the string has to appear, i.e. which element shall have that aria-label.
See #32060
@brianteeman I saw the issue but the description there is not clear. Meanwhile I found it: You have to be in the edit view of a stage and then use the action "Save & New". After that the aria-label of the form changes from "Edit Stage" to the untranslated text (when the PR is not applied).
Testing instructions updated. Please test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37393.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37393.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37393.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-28 23:21:51 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
a11y
|
||
Thx
Can you delete the old string?
On my phone so can't check if it's used elsewhere