Error only for one string
COM_WORKFLOW_STAGE_FORM_ADD="Add Stage"

Easier to modify code to use ADD instead of NEW as release is tomorrow Tuesday 29

<form action="<?php echo Route::_('index.php?option=com_workflow&view=stage&workflow_id=' . $input->getCmd('workflow_id') . '&extension=' . $input->getCmd('extension') . '&layout=' . $layout . $tmpl . '&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="workflow-form" aria-label="<?php echo Text::_('COM_WORKFLOW_STAGE_FORM_' . ((int) $this->item->id === 0 ? 'ADD' : 'EDIT'), true); ?>" class="form-validate">

The date of the release is irrelevant to the fix

The date of the release is irrelevant to the fix

It is not in this case. It is easier at this stage to modify the code as anyway the RC code is to be modified just before release to cope with security.

I suggest you think a bit further before writing.

and thats why we had such crap code all over the place that we now have to fix.

I guess it's me, but I'm checking with the latest RC and can't find the element. Would someone give me a screenshot/hint?

it's the aria-label

Yeah, I checked that, too

its easy to miss in the report but

Stage - New

Transition - New & Edit

Ah, ok, thanks. If someone could make a PR today, I can get it in for the 4.1.1 release.

Ah, ok, thanks. If someone could make a PR today, I can get it in for the 4.1.1 release.

@bembelimen PR for changing it in the PHP file? Or for adding a new language string in the language file?

And what about the 2nd error with the missing fieldset label? The discussion above was only about the first error.

Fix the language files

So be more clear:
it would be nice to have two PRs, one adding the strings to the language files, one fixing the label.

@bembelimen For point 1 see #37393 . With the missing label (point 2) I do not see any issue. It looks like it should here:

For the first point please test #37393 .

For the second point I see no issue. Even without a label, the tab title and the legend of the fieldset have the right value and are translated well.

And I see many other places where we have fieldsets without label.

But if I should add one, I would use text "COM_WORKFLOW_NOTIFICATION_FIELDSET_LABEL" because that's the text of the workflow notification plugin, and when that id disabled the notifications tab in the transition edit is not shown.

@brianteeman What do you think? Is that necessary and is it right?

just been loking at that one. its a bit tricky as its an injected plugin and the string is used for the tab title and the fieldset afaict

I cant see how/where t he compound string is being generated so the only option i am aware of is to create a new string

JGLOBAL_FIELDSET_PUBLISHING

@brianteeman We already have a string for that in the workflow notifications plugin. See PR #37394 .

yes - sorry. multitasking and failing

Closing as we have PRs now for both issues, see PRs #37393 and #37394 .