Feeling Lucky
?
Release Blocker
?
[#37374] - [4.2] Handle extensions when the installer script doesn't return a boolean
- Fixed in Code Base
- 26 Mar 2022
- Medium
- Build: 4.1-dev
- # 37374
- Digital-Peak:4/installer/handle-null
Pull Request for comment #37091 (comment).
Summary of Changes
Adds an extra check if the extension installer script returns a boolean in the routines.
Testing Instructions
Install any extension.
Actual result BEFORE applying this Pull Request
Some which do not return a boolean do fail like acymailing.
Expected result AFTER applying this Pull Request
All extension can be installed.
Votes
# of Users Experiencing Issue
1/1
Average Importance Score
5.00
laoneo
- comment
- 25 Mar 2022
Can you mark the test in the tracker? Thanks!
joomla-cms-bot
- | Category | ⇒ | Libraries |
joeforjoomla
- comment
- 25 Mar 2022
Can't mark as tested on the tracker
| Labels |
Added:
?
|
||
richard67
- comment
- 26 Mar 2022
I think it’s a release blocker.
richard67
- comment
- 26 Mar 2022
The patchtester seems to be one of these extensions, too.
joeforjoomla
- comment
- 26 Mar 2022
@richard67 almost all extensions out there have an installer function returning null
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-26 15:46:25 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
Release Blocker
|
||
fancyFranci
- comment
- 26 Mar 2022
Thank you for fixing that.
I confirm that the PR works and fixes the issue.