[#37362] - Add ability to save an article from the frontend without being redirected (#37312)
- Fixed in Code Base
- 26 Mar 2022
- Medium
- Build: 4.1-dev
- # 37362
- Diff
- MagnusSinger:i37312
User tests: Successful: Unsuccessful:
Pull Request for Issue #37312.
Summary of Changes
Added a new button to the article edit form on the frontend. It allows the user to save the article without closing the form. This corresponds with the functionality of the backend.
Testing Instructions
Edit an article from the frontend, the button will be on the bottom and you can save the article without being redirected
Actual result BEFORE applying this Pull Request
Only the ability to save the article and get redirected to it right afterward
Expected result AFTER applying this Pull Request
You can choose to only save the article and stay inside the edit form
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Title |
|
||||||
@bembelimen Is this a new feature and so has to go into 4.2? Or can it be considered a progressive enhancement so it's ok for 4.1.x (likely 4.1.2)?
4.2 please
@MagnusSinger Could you rebase the PR to 4.2-dev? Let us know if we shall help with that.
@richard67 yes sure
| Labels |
Added:
?
|
||
| Category | Front End com_content | ⇒ | Unit Tests Repository Administration com_associations com_banners com_cache com_categories com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages JavaScript com_media NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
@MagnusSinger You can add the new language string JSAVEANDCLOSE to the language/en-GB/joomla.ini file.
| Category | com_content Unit Tests Repository Administration com_associations com_banners com_cache com_categories com_contact com_fields com_finder com_installer com_joomlaupdate com_languages JavaScript com_media NPM Change | ⇒ | Front End com_content |
| Labels |
Added:
?
Removed: ? NPM Resource Changed ? |
||
| Category | com_content Front End | ⇒ | Front End com_content Language & Strings |
| Labels |
Added:
Language Change
|
||
@MagnusSinger Why would it not work? I see no reason why it would not work. Looking further we could improve it better like this:
$menuitem = (int) $params->get('redirect_menuitem');
if (in_array($this->getTask(), ['save2copy', 'apply'], true))
{
return $result;
}
// Check for redirection after submission when creating a new article only
if ($menuitem > 0 && $articleId == 0)
This works for me.
@ChristineWk Could you test again with the latest changes? Thanks in advance.
I have tested this item
Don't know if important as it's not part of this PR:
Also clicked: save as copy. Message: Save failed with the following error: Category is required. Would possibly fit there: #37354
But everything here refers to the frontend.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-26 17:26:05 |
| Closed_By | ⇒ | fancyFranci |
Thank you Magnus
Yes, congratulations @MagnusSinger to your (as far as I know) first merged pull request for Joomla CMS.
Thank you @fancyFranci and @richard67 and all the others for helping me with this. It was indeed my first pull request, and I'm looking forward to some more :)
I have tested this item✅ successfully on 6ffe565
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362.