? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
24 Mar 2022

Pull Request for Issue # .

Summary of Changes

In this PR I I added the "!default" setting to all the Cassiopeia variables. There where some variables who had already this setting in place, but now all variables are set as default. Setting the"!default" makes is easier for developers to create custom styling based on the Cassiopeia template for child themes for instance.

Use case:
After a child theme is created, create in the media/templates/site/CHILD_THEME a /scss folder
in this folder create a template.scss with the following content:

$secondary: red;
$success: red;
$info: red;
$warning: red;
$danger: red;

@import "../../cassiopeia/scss/template.scss";
// Your extra custom styling below

Next copy the template-rtl.scss from the media/templates/site/cassiopeia/scss folder to the child theme /scss folder.
Compile the template.scss and template-rtl.scss to the /css folder of the child theme
After compiling the CSS is build and the variable overrides are respected.
Set the child theme under the template settings in the backend and see the result.

Testing Instructions

Checkout this PR and compile the styling with npm ci.
Everything should work a normal.

avatar RickR2H RickR2H - open - 24 Mar 2022
avatar RickR2H RickR2H - change - 24 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2022
Category Repository NPM Change
avatar ricardo1709
ricardo1709 - comment - 24 Mar 2022

I have tested this item successfully on ab8a55e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

avatar ricardo1709 ricardo1709 - test_item - 24 Mar 2022 - Tested successfully
avatar RickR2H RickR2H - change - 24 Mar 2022
Labels Added: NPM Resource Changed ?
avatar MSnoeren
MSnoeren - comment - 25 Mar 2022

I have tested this item successfully on 59da1f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

avatar MSnoeren MSnoeren - test_item - 25 Mar 2022 - Tested successfully
avatar ricardo1709
ricardo1709 - comment - 25 Mar 2022

I have tested this item successfully on 59da1f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

avatar RickR2H RickR2H - change - 25 Mar 2022
Status Pending Ready to Commit
avatar ricardo1709 ricardo1709 - test_item - 25 Mar 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 25 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

avatar laoneo laoneo - change - 2 Apr 2022
Labels Added: ?
avatar laoneo laoneo - change - 2 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-02 13:25:04
Closed_By laoneo
avatar laoneo laoneo - close - 2 Apr 2022
avatar laoneo laoneo - merge - 2 Apr 2022
avatar laoneo
laoneo - comment - 2 Apr 2022

Thanks!

Add a Comment

Login with GitHub to post a comment