[#37348] - [4.1] Show search form param in Smart Search
- Closed
- 19 May 2022
- Medium
- Build: 4.1-dev
- # 37348
- Diff
- sakiss:show_search_form
User tests: Successful: Unsuccessful:
Pull Request for Issue #35692.
Replacement for #35967 and #37254
Summary of Changes
Parameter for showing the search form or not
Testing Instructions
A new setting named "Show Search Form" is added both in the Smart Search config and in it's search menu item.
By utilizing that parameter the smart search page can be used exclusively as a results page, without showing a search form. This is useful in case you have smart search modules that carry out the search.
Actual result BEFORE applying this Pull Request
Parameter not given
Expected result AFTER applying this Pull Request
Parameter is there
Documentation Changes Required
DKN
Sidenotes: The finder's script file is not loaded when the search form is not there. This was done for 2 reasons:
- A javascript error was thrown "Awesomplete does not exist". This is related with the order the scripts are loaded.
- This script has functionality exclusively for the search form. Otherwise it just adds to the page load.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Language & Strings Front End Modules |
| Title |
|
||||||
| Labels |
Added:
Language Change
?
|
||
Can you rebase this pr to the 4.2-dev branch as it is a new feature? Thanks.
Can you rebase this pr to the 4.2-dev branch as it is a new feature? Thanks.
It's not a new feature. Check the description.
What is it then, when it is not a feature?
I have tested this item
I'm not sure what's the purpose of hiding the search form in a search page, but the patch works and gives you the option
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37348.
@chmst and @bembelimen could you plz check if this is RTC? Would be great to have that fixed in the upcoming release.
Notice: Array to string conversion in \modules\mod_finder\src\Helper\FinderHelper.php on line 51
In Smart Search module, show Advanced Search.
Hide Search Form in menu item.
In the frontend, enter a search term, select a filter and perform search.
I suppose there is no any interest for that getting merged although @bembelimen urged me to go for it.
Pretty sure there is interest, but we need testers.
@laoneo afaik it needs 2 positive tests to get merged. Not?
Also it is really demotivating to ask for feedback from the RL and get radio silence for months.
The logical thought/outcome is that he does not care for your contribution and you waste your time here.
The same happened to my PRs again and again and i am really reluctant to invest any time here.
Yes it needs two tests. I'm with you that this is frustrating, but the RL has a lot of to do beside merging so he depends on testers.
It happens that i was involved with other projects in the past. Always my top priority was to keep the developers happy and motivated. When it comes to free open source where no any compensation involved i think this is imperative. Nobody is going to invest his time and knowledge for free, if he does not feel at least respected.
And another thing is that you really should rebase the pr to 4.2. Pretty sure then this will attract testers as 4.1 is patches only.
I really appreciate your work here and yes we need the two tests to get it merged, but as Allon said and I agree: it should be rebased to 4.2.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-19 10:57:01 |
| Closed_By | ⇒ | sakiss | |
| Labels |
Added:
PBF
|
||
I have tested this item✅ successfully on e671697
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37348.