@test - I have tested Roland's new PR with component.php changes - all OK.

Nice one, Roland!
You may blame the J!Tracker Application for transmitting this comment.

To be honest, I'm not a big fan of adding a parameter to do something that
is easily done with CSS. What is the problem that this solves?

Matt Thomas
203.632.9322
http://betweenbrain.com/

Sent from mobile. Please pardon any typos or brevity.
On Jun 7, 2014 1:53 AM, "RolandD" notifications@github.com wrote:

An updated PR for #1941 #1941.

Tracker: #32063

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32063&start=0

You can merge this Pull Request by running

git pull https://github.com/roland-d/joomla-cms isis-link-colour

Or view, comment on, or merge it at:

#3733
Commit Summary

• Added support to change link color in isis template (backend)

File Changes

• M administrator/language/en-GB/en-GB.tpl_isis.ini https://github.com/joomla/joomla-cms/pull/3733/files#diff-0 (2)
• M administrator/templates/isis/index.php https://github.com/joomla/joomla-cms/pull/3733/files#diff-1 (10)
• M administrator/templates/isis/language/en-GB/en-GB.tpl_isis.ini https://github.com/joomla/joomla-cms/pull/3733/files#diff-2 (2)
• M administrator/templates/isis/templateDetails.xml https://github.com/joomla/joomla-cms/pull/3733/files#diff-3 (7)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/3733.patch
• https://github.com/joomla/joomla-cms/pull/3733.diff

—
Reply to this email directly or view it on GitHub
#3733.

@betweenbrain The isis template already has colour options for nav bar, header and sidebar. So you can change colours there but the links don't follow this. The original TS added the option so the links will look the same as the rest. You can see the screenshots in the original PR.

Doing this change (which colour would one choose?) directly in CSS won't solve the problem of matching the other colors set in the template settings.

@sandstorm871 thanks mate.

@roland-d thanks for the explanation, I now better understand the underlying reason for this change.

What about making anchors the same color as the nav bar color, thus eliminating the added parameter?

@betweenbrain I was merely creating a PR against the correct branch and fixing the missing component.php file :)

Not sure I like having one color for 2 options. My preference would be to have a separate option for the anchors. Just gives the user a little bit more freedom.

We are in language freeze, reverted. Let's merge after 3.3.1 release

Patch applied with PatchTester and works as described

After discussing it with @davidhurley this will be included in the 3.4 release which in fact is technically better because it's a new (small) feature.

Merged into 3.4-dev.
Thanks!